From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 7/7] ASoC: codecs: wm8400: add _maybe_unused as needed
Date: Thu, 2 Jul 2020 10:07:13 -0500 [thread overview]
Message-ID: <3c2c9d10-0d7d-2447-01a6-3cf04836c34c@linux.intel.com> (raw)
In-Reply-To: <20200702092318.GL71940@ediswmail.ad.cirrus.com>
On 7/2/20 4:23 AM, Charles Keepax wrote:
> On Wed, Jul 01, 2020 at 01:13:20PM -0500, Pierre-Louis Bossart wrote:
>> Fix W=1 warning by adding __maybe_unused. Maintainers for this file
>> may want to double-check if those definitions are necessary.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>
> Yeah I think in this case better to remove them, they arn't used
> in the driver, the driver is pretty old and no one really works
> on it so little chance the features are ever getting added.
Thanks Charles, I can resend a v2 series with your Acked-by and remove
these definitions.
Out of curiosity, who can check the patch 1 and 2 (cs4270 / cs42l42)?
next prev parent reply other threads:[~2020-07-02 15:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:13 [PATCH 0/7] ASoC: codecs: wm/cs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
2020-07-01 18:13 ` [PATCH 1/7] ASoC: codecs: cs4270: fix kernel-doc Pierre-Louis Bossart
2020-07-01 18:13 ` [PATCH 2/7] ASoC: codecs: cs42l42: remove always-true comparisons Pierre-Louis Bossart
2020-07-01 18:13 ` [PATCH 3/7] ASoC: codecs: wm8986: fix missing kernel-doc arguments Pierre-Louis Bossart
2020-07-02 9:17 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 4/7] ASoC: codecs: wm8960: fix kernel-doc Pierre-Louis Bossart
2020-07-02 9:18 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 5/7] ASoC: codecs: wm9713: remove spurious kernel-doc comment start Pierre-Louis Bossart
2020-07-02 9:18 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 6/7] ASoC: codecs: wm8994: fix kernel-doc Pierre-Louis Bossart
2020-07-02 9:19 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 7/7] ASoC: codecs: wm8400: add _maybe_unused as needed Pierre-Louis Bossart
2020-07-02 9:23 ` Charles Keepax
2020-07-02 15:07 ` Pierre-Louis Bossart [this message]
2020-07-02 15:46 ` [PATCH 0/7] ASoC: codecs: wm/cs: fix kernel-doc and W=1 warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2c9d10-0d7d-2447-01a6-3cf04836c34c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.