From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu, "Daniel P. Berrangé" <berrange@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: Re: [PATCH] tests/unit: simpler variable sequence for test-io-channel
Date: Thu, 3 Nov 2022 11:27:55 +0100 [thread overview]
Message-ID: <3c9455e5-07cc-c1b5-bafd-7786153b5b9a@linaro.org> (raw)
In-Reply-To: <20221103102329.2581508-1-alex.bennee@linaro.org>
On 3/11/22 11:23, Alex Bennée wrote:
> This avoids some compilers complaining about a potentially
> un-initialised [src|dst]argv. In retrospect using GString was overkill
> for what we are constructing.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/unit/test-io-channel-command.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-11-03 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 10:23 [PATCH] tests/unit: simpler variable sequence for test-io-channel Alex Bennée
2022-11-03 10:27 ` Philippe Mathieu-Daudé [this message]
2022-11-03 10:28 ` Laurent Vivier
2022-11-03 11:32 ` Alex Bennée
2022-11-03 16:03 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9455e5-07cc-c1b5-bafd-7786153b5b9a@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.