From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>, linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH 0/2] block: Remove skd driver
Date: Thu, 4 Feb 2021 07:46:49 -0700 [thread overview]
Message-ID: <3cb4ca54-b916-5793-0632-bd12ff9d0006@kernel.dk> (raw)
In-Reply-To: <20210204084343.207847-1-damien.lemoal@wdc.com>
On 2/4/21 1:43 AM, Damien Le Moal wrote:
> Hi Jens,
>
> Instead of spending time fixing the skd driver to (at the very least)
> fix the call to set_capacity() with IRQ disabled, I am proposing to
> simply remove this driver. The STEC S1220 cards are EOL since 2014 and
> not supported by the vendor since several years ago. Given that these
> SSDs are very slow by today's NVMe standard, I do not think it is
> worthwhile to maintain this driver with newer kernel versions. I will
> keep addressing any problem that shows up with LTS versions.
>
> The first patch removes the skd driver and the second patch reverts
> commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver
> was the one driver that needed this (not so nice) fix.
>
> Please let me know what you think about this.
I'm fine with removing it. The 5.12 branch doesn't have the later
fix for the bd_size_lock issue, so could you just resend that once
the merge window opens and the block bits have gone in? In case I
forget...
--
Jens Axboe
next prev parent reply other threads:[~2021-02-04 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:43 [RFC PATCH 0/2] block: Remove skd driver Damien Le Moal
2021-02-04 8:43 ` [RFC PATCH 2/2] block: revert "block: fix bd_size_lock use" Damien Le Moal
2021-02-04 9:01 ` Johannes Thumshirn
2021-02-04 9:03 ` Damien Le Moal
2021-02-04 9:14 ` Johannes Thumshirn
2021-02-04 9:16 ` Damien Le Moal
2021-02-04 9:20 ` Damien Le Moal
2021-02-04 9:25 ` Johannes Thumshirn
2021-02-04 9:26 ` Damien Le Moal
2021-02-04 14:46 ` Jens Axboe [this message]
2021-02-04 14:52 ` [RFC PATCH 0/2] block: Remove skd driver Damien Le Moal
2021-02-04 14:54 ` Jens Axboe
2021-02-04 14:57 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb4ca54-b916-5793-0632-bd12ff9d0006@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.