From: Gavin Shan <gshan@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com,
catalin.marinas@arm.com, will@kernel.org,
akpm@linux-foundation.org, chuhu@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH v2 00/12] mm/debug_vm_pgtable: Enhancements
Date: Mon, 19 Jul 2021 21:34:05 +1000 [thread overview]
Message-ID: <3d0a3a3b-e0ce-bf13-c8ce-de93a6f21c2d@redhat.com> (raw)
In-Reply-To: <20210719054138.198373-1-gshan@redhat.com>
Hi Anshuman,
On 7/19/21 3:41 PM, Gavin Shan wrote:
> There are couple of issues with current implementations and this series
> tries to resolve the issues:
>
> (a) All needed information are scattered in variables, passed to various
> test functions. The code is organized in pretty much relaxed fashion.
>
> (b) The page isn't allocated from buddy during page table entry modifying
> tests. The page can be invalid, conflicting to the implementations
> of set_xxx_at() on ARM64. The target page is accessed so that the iCache
> can be flushed when execution permission is given on ARM64. Besides,
> the target page can be unmapped and access to it causes kernel crash.
>
> "struct pgtable_debug_args" is introduced to address issue (a). For issue
> (b), the used page is allocated from buddy in page table entry modifying
> tests. The corresponding tets will be skipped if we fail to allocate the
> (huge) page. For other test cases, the original page around to kernel
> symbol (@start_kernel) is still used.
>
> The patches are organized as below. PATCH[2-10] could be combined to one
> patch, but it will make the review harder:
>
> PATCH[1] introduces "struct pgtable_debug_args" as place holder of all
> needed information. With it, the old and new implementation
> can coexist.
> PATCH[2-10] uses "struct pgtable_debug_args" in various test functions.
> PATCH[11] removes the old implementation.
> PATCH[12] fixes the issue of corrupted page flag for ARM64
>
> Changelog
> =========
> v2:
> * Rename struct vm_pgtable_debug to struct pgtable_debug_args.
> The parameter name to various test functions are renamed
> to "@args" (Anshuman)
> * Code changes as suggested by Anshuman (Anshuman)
>
Please ignore v2. I will post v3 to fix couple of issues in v2:
(1) The subjects of PATCH[5/12] and PATCH[9/12] should be fixed to
start with "mm/debug_vm_pgtable".
(2) "WARN_ON(!pud_none(pud))" is missed in PATCH[9/12]. Otherwise,
build warning for unused variable @pud is raised.
(3) Build warnings for unused variables in separate patches are
raised, reported by 0-DAY CI Kernel Test Service.
Thanks,
Gavin
> Gavin Shan (12):
> mm/debug_vm_pgtable: Introduce struct pgtable_debug_args
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and
> savewrite tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and
> devmap tests
> mm/vm_debug_pgtable: Use struct pgtable_debug_args in soft_dirty and
> swap tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and
> thp tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying
> tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD
> mm/vm_debug_pgtable: Use struct pgtable_debug_args in PUD modifying
> tests
> mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D
> modifying tests
> mm/debug_vm_pgtable: Remove unused code
> mm/debug_vm_pgtable: Fix corrupted page flag
>
> mm/debug_vm_pgtable.c | 849 ++++++++++++++++++++++++------------------
> 1 file changed, 479 insertions(+), 370 deletions(-)
>
prev parent reply other threads:[~2021-07-19 11:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 5:41 [PATCH v2 00/12] mm/debug_vm_pgtable: Enhancements Gavin Shan
2021-07-19 5:41 ` [PATCH v2 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args Gavin Shan
2021-07-19 13:01 ` Gavin Shan
2021-07-20 6:42 ` Anshuman Khandual
2021-07-20 23:29 ` Gavin Shan
2021-07-21 4:50 ` Anshuman Khandual
2021-07-21 12:09 ` Gavin Shan
2021-07-19 5:41 ` [PATCH v2 02/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 03/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 04/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 05/12] mm/vm_debug_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 06/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 07/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests Gavin Shan
2021-07-19 5:41 ` [PATCH v2 08/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD Gavin Shan
2021-07-19 5:41 ` [PATCH v2 09/12] mm/vm_debug_pgtable: Use struct pgtable_debug_args in PUD modifying tests Gavin Shan
2021-07-19 9:13 ` kernel test robot
2021-07-19 9:13 ` kernel test robot
2021-07-19 11:30 ` Gavin Shan
2021-07-19 11:30 ` Gavin Shan
2021-07-20 2:46 ` kernel test robot
2021-07-20 2:46 ` kernel test robot
2021-07-20 23:09 ` Gavin Shan
2021-07-20 23:09 ` Gavin Shan
2021-07-19 5:41 ` [PATCH v2 10/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D " Gavin Shan
2021-07-19 5:41 ` [PATCH v2 11/12] mm/debug_vm_pgtable: Remove unused code Gavin Shan
2021-07-19 5:41 ` [PATCH v2 12/12] mm/debug_vm_pgtable: Fix corrupted page flag Gavin Shan
2021-07-19 11:34 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d0a3a3b-e0ce-bf13-c8ce-de93a6f21c2d@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=chuhu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.