Re: [PATCH iproute2] ip link: add sub-command to view and change DSA master

From: David Ahern <dsahern@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Stephen Hemminger <stephen@networkplumber.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH iproute2] ip link: add sub-command to view and change DSA master
Date: Thu, 8 Sep 2022 08:08:23 -0600	[thread overview]
Message-ID: <403f6f3b-ba65-bdb2-4f02-f9520768b0f6@kernel.org> (raw)
In-Reply-To: <20220908125117.5hupge4r7nscxggs@skbuf>

On 9/8/22 6:51 AM, Vladimir Oltean wrote:
> On Tue, Sep 06, 2022 at 01:33:09PM -0700, Florian Fainelli wrote:
>> On 9/6/2022 1:05 PM, Andrew Lunn wrote:
>>>> [ Alternative answer: how about "schnauzer"? I always liked how that word sounds. ]
>>>
>>> Unfortunately, it is not gender neutral, which i assume is a
>>> requirement?
>>>
>>> Plus the plural is also schnauzer, which would make your current
>>> multiple CPU/schnauzer patches confusing, unless you throw the rule
>>> book out and use English pluralisation.
>>
>> What a nice digression, I had no idea you two mastered German that well :).
>> How about "conduit" or "mgmt_port" or some variant in the same lexicon?
> 
> Proposing any alternative naming raises the question how far you want to
> go with the alternative name. No user of DSA knows the "conduit interface"
> or "management port" or whatnot by any other name except "DSA master".
> What do we do about the user-visible Documentation/networking/dsa/configuration.rst,
> which clearly and consistently uses the 'master' name everywhere?
> Do we replace 'master' with something else and act as if it was never
> named 'master' in the first place? Do we introduce IFLA_DSA_MGMT_PORT as
> UAPI and explain in the documentation "oh yeah, that's how you change
> the DSA master"? "Ahh ok, why didn't you just call it IFLA_DSA_MASTER
> then?" "Well...."
> 
> Also, what about the code in net/dsa/*.c and drivers/net/dsa/, do we
> also change that to reflect the new terminology, or do we just have
> documentation stating one thing and the code another?
> 
> At this stage, I'm much more likely to circumvent all of this, and avoid
> triggering anyone by making a writable IFLA_LINK be the mechanism through
> which we change the DSA master.

IMHO, 'master' should be an allowed option giving the precedence of
existing code and existing terminology. An alternative keyword can be
used for those that want to avoid use of 'master' in scripts. vrf is an
example of this -- you can specify 'vrf <device>' as a keyword instead
of 'master <vrf>'