Re: [PATCH 12/15] drm/i915: Extract common cleanup into i915_ppgtt_release

From: "Thierry, Michel" <michel.thierry@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 12/15] drm/i915: Extract common cleanup into	i915_ppgtt_release
Date: Fri, 8 Aug 2014 13:07:25 +0000	[thread overview]
Message-ID: <40F8A24546556F4F886C42CCE2ED59E51B2C1014@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1407330298-27065-12-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 2086 bytes --]


> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Daniel Vetter
> Sent: Wednesday, August 06, 2014 2:05 PM
> To: Intel Graphics Development
> Cc: Daniel Vetter
> Subject: [Intel-gfx] [PATCH 12/15] drm/i915: Extract common cleanup into
> i915_ppgtt_release
> 
> Address space cleanup isn't really a job for the low-level cleanup
> callbacks. Without this change we can't reuse the low-level cleanup
> callback for the aliasing ppgtt cleanup.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
> b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index a4c1740d79be..bbf113ed7339 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -403,9 +403,6 @@ static void gen8_ppgtt_cleanup(struct
> i915_address_space *vm)
>  	struct i915_hw_ppgtt *ppgtt =
>  		container_of(vm, struct i915_hw_ppgtt, base);
> 
> -	list_del(&vm->global_link);
> -	drm_mm_takedown(&vm->mm);
> -
>  	gen8_ppgtt_unmap_pages(ppgtt);
>  	gen8_ppgtt_free(ppgtt);
>  }
> @@ -1029,8 +1026,6 @@ static void gen6_ppgtt_cleanup(struct
> i915_address_space *vm)
>  	struct i915_hw_ppgtt *ppgtt =
>  		container_of(vm, struct i915_hw_ppgtt, base);
> 
> -	list_del(&vm->global_link);
> -	drm_mm_takedown(&ppgtt->base.mm);
>  	drm_mm_remove_node(&ppgtt->node);
> 
>  	gen6_ppgtt_unmap_pages(ppgtt);
> @@ -1255,6 +1250,9 @@ void  i915_ppgtt_release(struct kref *kref)
>  	WARN_ON(!list_empty(&ppgtt->base.active_list));
>  	WARN_ON(!list_empty(&ppgtt->base.inactive_list));
> 
> +	list_del(&ppgtt->base.global_link);
> +	drm_mm_takedown(&ppgtt->base.mm);
> +
>  	ppgtt->base.cleanup(&ppgtt->base);
>  	kfree(ppgtt);
>  }
> --
> 1.9.3

Reviewed-by: Michel Thierry <michel.thierry@intel.com>
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 6656 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx