From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
mchehab@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, robert.foss@linaro.org,
hfink@snap.com, jgrahsl@snap.com, dmitry.baryshkov@linaro.org,
vladimir.zapolskiy@linaro.org
Subject: Re: [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support
Date: Thu, 14 Apr 2022 23:32:45 +0100 [thread overview]
Message-ID: <418b73f1-a5b9-ce07-1fc1-736107f36c41@linaro.org> (raw)
In-Reply-To: <YliZIqg201pDH1aH@valkosipuli.retiisi.eu>
On 14/04/2022 22:58, Sakari Ailus wrote:
> It's still wrong and should be fixed. It seems there are no boards in the
> DT source in the kernel using this sensor. These changes seem fine to me.
>
> I'm not really worried about ACPI: it's unlikely the GPIO is even declared
> for the sensor, and instead is controlled in AML. There can of course be
> bugs in ACPI tables, too...
Hmm.
OK well I'll add the GPIO patch in for V5 but with a putative guard in
for ACPI, inverting the logic.
We can always pull the guard if it turns out not be necessary.
---
bod
prev parent reply other threads:[~2022-04-14 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 12:45 [PATCH v3 0/2] media: i2c: imx412: Add regulator control to imx412 Bryan O'Donoghue
2022-04-14 12:45 ` [PATCH v3 1/2] media: dt-bindings: imx412: Add regulator descriptions Bryan O'Donoghue
2022-04-14 12:45 ` [PATCH v3 2/2] media: i2c: imx412: Add bulk regulator support Bryan O'Donoghue
2022-04-14 13:00 ` Sakari Ailus
2022-04-14 13:44 ` Bryan O'Donoghue
2022-04-14 13:56 ` Sakari Ailus
2022-04-14 14:04 ` Bryan O'Donoghue
2022-04-14 14:16 ` Sakari Ailus
2022-04-14 14:50 ` Bryan O'Donoghue
2022-04-14 21:58 ` Sakari Ailus
2022-04-14 22:32 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418b73f1-a5b9-ce07-1fc1-736107f36c41@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hfink@snap.com \
--cc=jgrahsl@snap.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robert.foss@linaro.org \
--cc=sakari.ailus@iki.fi \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.