From: Amir Mizinski <amirmizi6@gmail.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com,
alexander.steffen@infineon.com, robh+dt@kernel.org,
mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org, benoit.houyere@st.com,
eajames@linux.ibm.com, joel@jms.id.au,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com
Subject: Re: [PATCH v7 3/7] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"
Date: Thu, 30 Apr 2020 10:29:08 +0000 [thread overview]
Message-ID: <41fd551b-e678-32bb-781d-48cfe1a3c5bb@gmail.com> (raw)
In-Reply-To: <20200429053703.GF8452@linux.intel.com>
On 2020-04-29 05:37, Jarkko Sakkinen wrote:
> On Mon, Apr 27, 2020 at 03:49:27PM +0300, amirmizi6@gmail.com wrote:
>> From: Amir Mizinski <amirmizi6@gmail.com>
>>
>> Using this function while reading/writing data resulted in an aborted
>> operation.
>> After investigating the issue according to the TCG TPM Profile (PTP)
>> Specifications, I found that "request to cancel" should occur only if
>> TPM_STS.commandReady bit is lit.
>> Note that i couldn't find a case where the present condition
>> (in the linux kernel) is valid, so I'm removing the case for
>> "TPM_VID_WINBOND" since we have no need for it.
>>
>> Also, the default comparison is wrong. Only cmdReady bit needs to be
>> compared instead of the full lower status register byte.
>>
>> Fixes: 1f86605 (tpm: Fix cancellation of TPM commands (polling mode))
>
> Needs to have exactly 12 hex digits of the hash.
>
Ok, i'll fix this for version 8. Thank you.
> /Jarkko
next prev parent reply other threads:[~2020-04-30 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 12:49 [PATCH v7 0/7] Add tpm i2c ptp driver amirmizi6
2020-04-27 12:49 ` [PATCH v7 1/7] tpm: tpm_tis: Make implementation of read16, read32 and write32 optional amirmizi6
2020-04-27 12:49 ` [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy tpm_tis_phy_ops amirmizi6
2020-04-29 5:34 ` Jarkko Sakkinen
2020-04-30 10:19 ` Amir Mizinski
2020-04-27 12:49 ` [PATCH v7 3/7] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2020-04-29 5:37 ` Jarkko Sakkinen
2020-04-30 10:29 ` Amir Mizinski [this message]
2020-04-27 12:49 ` [PATCH v7 4/7] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2020-04-27 12:49 ` [PATCH v7 5/7] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2020-04-27 12:49 ` [PATCH v7 6/7] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2020-05-05 16:12 ` Rob Herring
2020-05-06 15:20 ` Amir Mizinski
2020-05-06 19:02 ` Rob Herring
2020-04-27 12:49 ` [PATCH v7 7/7] tpm: tpm_tis: add tpm_tis_i2c driver amirmizi6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41fd551b-e678-32bb-781d-48cfe1a3c5bb@gmail.com \
--to=amirmizi6@gmail.com \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=arnd@arndb.de \
--cc=benoit.houyere@st.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.