From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 2/6] drm/omap: Rename enum omap_plane to enum omap_plane_id
Date: Fri, 31 Mar 2017 01:09:47 +0300 [thread overview]
Message-ID: <42600149.KCNBAcA83i@avalon> (raw)
In-Reply-To: <172b474774a6815f235357b7e08b3c36b89269ba.1490366823.git.jsarha@ti.com>
Hi Jyri,
On Friday 24 Mar 2017 16:47:52 Jyri Sarha wrote:
> The enum omap_plane conflicted with the same struct name for omapdrm
> plane private data. This rename should solve the conflict.
>
> The rename was implement with this very simple coccinelle patch:
> ------------------------
> @@
> @@
> enum
> -omap_plane
> +omap_plane_id
> ------------------------
> The patch was applied like this:
> spatch --sp-file <cocci_file> --all-includes --in-place --dir
> drivers/gpu/drm/omapdrm
>
> The above patch did not rename the actual enum definition. That was
> added manually on top of the spatch changes.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 124 +++++++++++++-------------
> drivers/gpu/drm/omapdrm/dss/dispc.h | 62 +++++++--------
> drivers/gpu/drm/omapdrm/dss/dss.h | 5 +-
> drivers/gpu/drm/omapdrm/dss/dss_features.c | 6 +-
> drivers/gpu/drm/omapdrm/dss/dss_features.h | 6 +-
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 17 ++--
> 6 files changed, 117 insertions(+), 103 deletions(-)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-30 22:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:47 [PATCH v4 0/6] drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS, cleanup & CTM Jyri Sarha
2017-03-24 14:47 ` [PATCH v4 1/6] drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config option Jyri Sarha
2017-03-30 21:58 ` Laurent Pinchart
2017-03-24 14:47 ` [PATCH v4 2/6] drm/omap: Rename enum omap_plane to enum omap_plane_id Jyri Sarha
2017-03-30 22:09 ` Laurent Pinchart [this message]
2017-03-24 14:47 ` [PATCH v4 3/6] drm/omap: Fix one ugly indentation style break left by coccinelle Jyri Sarha
2017-03-30 22:10 ` Laurent Pinchart
2017-03-24 14:47 ` [PATCH v4 4/6] drm/omap: Remove the obsolete #define omap_plane _omap_plane hack Jyri Sarha
2017-03-30 22:11 ` Laurent Pinchart
2017-03-24 14:47 ` [PATCH v4 5/6] drm/omap: Major omap_modeset_init() cleanup Jyri Sarha
2017-03-24 14:47 ` [PATCH v4 6/6] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix Jyri Sarha
2017-03-30 22:44 ` Laurent Pinchart
2017-03-29 7:47 ` [PATCH v4 0/6] drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS, cleanup & CTM Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42600149.KCNBAcA83i@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.