Re: [wpan-next v2 3/9] net: ieee802154: mcr20a: Fix lifs/sifs periods

From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Alexander Aring <alex.aring@gmail.com>,
	linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, Xue Liu <liuxuenetmail@gmail.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Harry Morris <harrymorris12@gmail.com>,
	David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [wpan-next v2 3/9] net: ieee802154: mcr20a: Fix lifs/sifs periods
Date: Fri, 21 Jan 2022 17:01:45 +0100	[thread overview]
Message-ID: <43295627-66c0-3dee-3127-ae9d60eaf8fe@datenfreihafen.org> (raw)
In-Reply-To: <20220120112115.448077-4-miquel.raynal@bootlin.com>

Hello Xue.

You are still listed as maintainer for the mcr20a driver, thus this mail.

On 20.01.22 12:21, Miquel Raynal wrote:
> These periods are expressed in time units (microseconds) while 40 and 12
> are the number of symbol durations these periods will last. We need to
> multiply them both with phy->symbol_duration in order to get these
> values in microseconds.
> 
> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   drivers/net/ieee802154/mcr20a.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index 8dc04e2590b1..383231b85464 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -976,8 +976,8 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp)
>   	dev_dbg(printdev(lp), "%s\n", __func__);
>   
>   	phy->symbol_duration = 16;
> -	phy->lifs_period = 40;
> -	phy->sifs_period = 12;
> +	phy->lifs_period = 40 * phy->symbol_duration;
> +	phy->sifs_period = 12 * phy->symbol_duration;

To me this looks correct and I would go ahead and apply it. Xue, if you 
disagree please reply and explain why.

regards
Stefan Schmidt