All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
	drjones@redhat.com
Subject: Re: [kvm-unit-tests PATCH v12 9/9] s390x: css: ssch/tsch with sense and interrupt
Date: Wed, 15 Jul 2020 12:49:30 +0200	[thread overview]
Message-ID: <4363ac1a-d8a9-b6f7-785f-aa293c44215a@linux.ibm.com> (raw)
In-Reply-To: <20200715121523.1a4244fb.cohuck@redhat.com>



On 2020-07-15 12:15, Cornelia Huck wrote:
> On Tue, 14 Jul 2020 13:15:48 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
> 
>> After a channel is enabled we start a SENSE_ID command using
>> the SSCH instruction to recognize the control unit and device.
>>
>> This tests the success of SSCH, the I/O interruption and the TSCH
>> instructions.
>>
>> The SENSE_ID command response is tested to report 0xff inside
>> its reserved field and to report the same control unit type
>> as the cu_type kernel argument.
>>
>> Without the cu_type kernel argument, the test expects a device
>> with a default control unit type of 0x3832, a.k.a virtio-net-ccw.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>>   lib/s390x/asm/arch_def.h |   1 +
>>   lib/s390x/css.h          |  35 ++++++++
>>   lib/s390x/css_lib.c      | 180 +++++++++++++++++++++++++++++++++++++++
>>   s390x/css.c              |  80 +++++++++++++++++
>>   4 files changed, 296 insertions(+)
> 
> Other than the padding issue, looks good to me now.
> 

Thanks, so one last respin. :)


-- 
Pierre Morel
IBM Lab Boeblingen

      reply	other threads:[~2020-07-15 10:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 11:15 [kvm-unit-tests PATCH v12 0/9] s390x: Testing the Channel Subsystem I/O Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 1/9] s390x: saving regs for interrupts Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 2/9] s390x: I/O interrupt registration Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 3/9] s390x: export the clock get_clock_ms() utility Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 4/9] s390x: clock and delays calculations Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 5/9] s390x: define function to wait for interrupt Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 6/9] s390x: Library resources for CSS tests Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 7/9] s390x: css: stsch, enumeration test Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 8/9] s390x: css: msch, enable test Pierre Morel
2020-07-14 11:15 ` [kvm-unit-tests PATCH v12 9/9] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2020-07-14 11:38   ` Thomas Huth
2020-07-14 11:51     ` Pierre Morel
2020-07-15 10:15   ` Cornelia Huck
2020-07-15 10:49     ` Pierre Morel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4363ac1a-d8a9-b6f7-785f-aa293c44215a@linux.ibm.com \
    --to=pmorel@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=drjones@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.