From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v2 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings
Date: Thu, 13 May 2021 13:52:09 +0300 [thread overview]
Message-ID: <43b7c7dd-5a8a-b1ae-b2ad-c9fd158a3922@virtuozzo.com> (raw)
In-Reply-To: <20210512174318.59466-3-mreitz@redhat.com>
12.05.2021 20:43, Max Reitz wrote:
> pylint complains that discards1_sha256 and all_discards_sha256 are first
> set in non-__init__ methods.
>
> These variables are not really class-variables anyway, so let them
> instead be returned by start_postcopy(), thus silencing pylint.
>
> Suggested-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
> Signed-off-by: Max Reitz<mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-05-13 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:43 [PATCH v2 0/4] iotests/297: Cover tests/ Max Reitz
2021-05-12 17:43 ` [PATCH v2 1/4] iotests/297: Drop 169 and 199 from the skip list Max Reitz
2021-05-12 17:43 ` [PATCH v2 2/4] migrate-bitmaps-postcopy-test: Fix pylint warnings Max Reitz
2021-05-13 10:52 ` Vladimir Sementsov-Ogievskiy [this message]
2021-05-12 17:43 ` [PATCH v2 3/4] migrate-bitmaps-test: " Max Reitz
2021-05-12 17:43 ` [PATCH v2 4/4] iotests/297: Cover tests/ Max Reitz
2021-05-14 11:02 ` [PATCH v2 0/4] " Max Reitz
2021-05-14 15:08 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b7c7dd-5a8a-b1ae-b2ad-c9fd158a3922@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.