Re: [PATCH -next] bus: qcom: Use devm_platform_ioremap_resource()

From: Caleb Connolly <caleb.connolly@linaro.org>
To: Yang Li <yang.lee@linux.alibaba.com>, agross@kernel.org
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] bus: qcom: Use devm_platform_ioremap_resource()
Date: Fri, 28 Apr 2023 17:29:32 +0100	[thread overview]
Message-ID: <4403b1fa-3bce-3f4f-183f-a8353df42dfd@linaro.org> (raw)
In-Reply-To: <20230428065210.30095-1-yang.lee@linux.alibaba.com>


On 28/04/2023 07:52, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>   drivers/bus/qcom-ebi2.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
> index c1fef1b4bd89..01e76bb05218 100644
> --- a/drivers/bus/qcom-ebi2.c
> +++ b/drivers/bus/qcom-ebi2.c
> @@ -294,7 +294,6 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
>   	struct device_node *np = pdev->dev.of_node;
>   	struct device_node *child;
>   	struct device *dev = &pdev->dev;
> -	struct resource *res;
>   	void __iomem *ebi2_base;
>   	void __iomem *ebi2_xmem;
>   	struct clk *ebi2xclk;
> @@ -325,15 +324,13 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
>   		goto err_disable_2x_clk;
>   	}
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ebi2_base = devm_ioremap_resource(dev, res);
> +	ebi2_base = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(ebi2_base)) {
>   		ret = PTR_ERR(ebi2_base);
>   		goto err_disable_clk;
>   	}
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	ebi2_xmem = devm_ioremap_resource(dev, res);
> +	ebi2_xmem = devm_platform_ioremap_resource(pdev, 1);
>   	if (IS_ERR(ebi2_xmem)) {
>   		ret = PTR_ERR(ebi2_xmem);
>   		goto err_disable_clk;