From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org
Cc: Alex Elder <elder@linaro.org>
Subject: Re: [PATCH] rbd: nuke the 32-bit pool id check
Date: Tue, 9 Aug 2016 09:45:50 -0500 [thread overview]
Message-ID: <446d126b-1e14-e93f-456f-a9f48fdcdddf@ieee.org> (raw)
In-Reply-To: <1470753737-5729-1-git-send-email-idryomov@gmail.com>
On 08/09/2016 09:42 AM, Ilya Dryomov wrote:
> ceph_file_layout::pool_id is now s64. rbd_add_get_pool_id() and
> ceph_pg_poolid_by_name() both return an int, so it's bogus anyway.
>
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
If a pool id is really 64 bits (signed), shouldn't
rbd_add_get_pool_id() and ceph_pg_poolid_by_name()
be changed to return that type (first)?
This otherwise looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/block/rbd.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 07668a6f0607..6c6519f6492a 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5337,15 +5337,6 @@ static ssize_t do_rbd_add(struct bus_type *bus,
> }
> spec->pool_id = (u64)rc;
>
> - /* The ceph file layout needs to fit pool id in 32 bits */
> -
> - if (spec->pool_id > (u64)U32_MAX) {
> - rbd_warn(NULL, "pool id too large (%llu > %u)",
> - (unsigned long long)spec->pool_id, U32_MAX);
> - rc = -EIO;
> - goto err_out_client;
> - }
> -
> rbd_dev = rbd_dev_create(rbdc, spec, rbd_opts);
> if (!rbd_dev) {
> rc = -ENOMEM;
>
next prev parent reply other threads:[~2016-08-09 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 14:42 [PATCH] rbd: nuke the 32-bit pool id check Ilya Dryomov
2016-08-09 14:45 ` Alex Elder [this message]
2016-08-09 14:51 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446d126b-1e14-e93f-456f-a9f48fdcdddf@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@linaro.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.