Re: [PATCH 00/20] tests/9p: introduce declarative function calls

From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH 00/20] tests/9p: introduce declarative function calls
Date: Thu, 13 Oct 2022 15:34:54 +0200	[thread overview]
Message-ID: <4473521.5piZKajXiT@silver> (raw)
In-Reply-To: <20221012155806.64f67dc8@bahia>

On Mittwoch, 12. Oktober 2022 15:58:06 CEST Greg Kurz wrote:
> On Wed, 12 Oct 2022 12:00:40 +0200
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> 
> > On Dienstag, 4. Oktober 2022 22:56:44 CEST Christian Schoenebeck wrote:
> > > This series converts relevant 9p (test) client functions to use named
> > > function arguments. For instance
> > > 
> > >     do_walk_expect_error(v9p, "non-existent", ENOENT);
> > > 
> > > becomes
> > > 
> > >     twalk({
> > >         .client = v9p, .path = "non-existent", .expectErr = ENOENT
> > >     });
> > > 
> > > The intention is to make the actual 9p test code more readable, and 
easier
> > > to maintain on the long-term.
> > > 
> > > Not only makes it clear what a literal passed to a function is supposed 
to
> > > do, it also makes the order and selection of arguments very liberal, and
> > > allows to merge multiple, similar functions into one single function.
> > > 
> > > This is basically just refactoring, it does not change behaviour.
> > 
> > Too massive for review?
> > 
> 
> Yeah, sorry :-(
> 
> But since the approach you're taking here may be valuable elsewhere,
> and this is qtest, it seems fair to ask Thomas and Laurent to have
> a look :-)

Thomas, Laurent, if you had some spare cycles to look at this, that would be 
much appreciated!

Otherwise if not possible then I'll go ahead with PR next week as said.

Best regards,
Christian Schoenebeck