Re: [PATCH v2 2/4] drm/omap: hdmi4: Ensure the device is active during bind

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/4] drm/omap: hdmi4: Ensure the device is active during bind
Date: Mon, 05 Nov 2018 23:45:21 +0200	[thread overview]
Message-ID: <4473857.quWqT8yViU@avalon> (raw)
In-Reply-To: <20181105200247.GD56754@atomide.com>

Hi Tony,

On Monday, 5 November 2018 22:02:47 EET Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [181105 15:10]:
> > The bind function performs hardware access (in hdmi4_cec_init()) and
> > thus requires the device to be active. Ensure this by surrounding the
> > bind function by hdmi_runtime_get() and hdmi_runtime_put() calls.
> > 
> > Fixes: 27d624527d99 ("drm/omap: dss: Acquire next dssdev at probe time")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Looks good to me except one typo below..
> 
> > index cf6230eac31a..36be9a36d664 100644
> > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c

[snip]

> > @@ -652,12 +656,16 @@ static int hdmi4_bind(struct device *dev, struct
> > device *master, void *data)
> >  	hdmi->debugfs = dss_debugfs_create_file(dss, "hdmi", hdmi_dump_regs,
> >  					       hdmi);
> > 
> > +	hdmi_runtime_put(hdmi);
> > +
> >  	return 0;
> >  
> >  err_cec_uninit:
> >  	hdmi4_cec_uninit(&hdmi->core);
> >  err_pll_uninit:
> >  	hdmi_pll_uninit(&hdmi->pll);
> > +err_runtime_put:
> > +	hdmi_runtime_get(hdmi);
> >  	return r;
> >  }
> 
> At err_runtime_put you should call hdmi_runtime_put() instead of
> hdmi_runtime_get(), right? :)

Oops. Of course. Thank you for the review. This will be fixed in v3.

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel