Re: [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"

From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "José Expósito" <jose.exposito89@gmail.com>, jkosina@suse.cz
Cc: tiwai@suse.de, benjamin.tissoires@redhat.com,
	regressions@leemhuis.info, peter.hutterer@who-t.net,
	linux-input@vger.kernel.org, stable@vger.kernel.org,
	regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"
Date: Wed, 30 Mar 2022 14:27:26 +0200	[thread overview]
Message-ID: <44abc738-1532-63fa-9cd1-2b3870a963bc@leemhuis.info> (raw)
In-Reply-To: <20220321184404.20025-1-jose.exposito89@gmail.com>

Hi, this is your Linux kernel regression tracker.

On 21.03.22 19:44, José Expósito wrote:
> This reverts commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40.
> 
> The touchpad present in the Dell Precision 7550 and 7750 laptops
> reports a HID_DG_BUTTONTYPE of type MT_BUTTONTYPE_CLICKPAD. However,
> the device is not a clickpad, it is a touchpad with physical buttons.
> 
> In order to fix this issue, a quirk for the device was introduced in
> libinput [1] [2] to disable the INPUT_PROP_BUTTONPAD property:
> 
> 	[Precision 7x50 Touchpad]
> 	MatchBus=i2c
> 	MatchUdevType=touchpad
> 	MatchDMIModalias=dmi:*svnDellInc.:pnPrecision7?50*
> 	AttrInputPropDisable=INPUT_PROP_BUTTONPAD
> 
> However, because of the change introduced in 37ef4c19b4 ("Input: clear
> BTN_RIGHT/MIDDLE on buttonpads") the BTN_RIGHT key bit is not mapped
> anymore breaking the device right click button and making impossible to
> workaround it in user space.
> 
> In order to avoid breakage on other present or future devices, revert
> the patch causing the issue.
> 
> Cc: stable@vger.kernel.org
> Link: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/481 [1]
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868789  [2]
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> [...]

Jiri, Benjamin, what the status here? Sure, this is not a crucial
regression and we are in the middle of the merge window, but it looks
like nothing has happened for a week now. Or was progress made somewhere
and I just missed it?

#regzbot ^backmonitor:
https://lore.kernel.org/stable/s5htubv32s8.wl-tiwai@suse.de/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.