From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
"Richard W . M . Jones" <rjones@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 1/1] util/uri: do not check argument of uri_free()
Date: Tue, 29 Jun 2021 06:34:26 +0200 [thread overview]
Message-ID: <451d1c59-9043-15b6-af97-87880978f7e3@redhat.com> (raw)
In-Reply-To: <20210628215526.50324-1-xypron.glpk@gmx.de>
On 6/28/21 11:55 PM, Heinrich Schuchardt wrote:
> uri_free() checks if its argument is NULL in uri_clean() and g_free().
> There is no need to check the argument before the call.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> block/nfs.c | 4 +---
> block/ssh.c | 4 +---
> capstone | 2 +-
> util/uri.c | 22 ++++++----------------
> 4 files changed, 9 insertions(+), 23 deletions(-)
Looks good ...
> diff --git a/capstone b/capstone
> index f8b1b83301..31254f17e3 160000
> --- a/capstone
> +++ b/capstone
> @@ -1 +1 @@
> -Subproject commit f8b1b833015a4ae47110ed068e0deb7106ced66d
> +Subproject commit 31254f17e3c6025f3465d1c974a8c96e338ddbe0
... except this change.
prev parent reply other threads:[~2021-06-29 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 21:55 [PATCH 1/1] util/uri: do not check argument of uri_free() Heinrich Schuchardt
2021-06-29 4:34 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451d1c59-9043-15b6-af97-87880978f7e3@redhat.com \
--to=philmd@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.