From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, amitk@kernel.org, linux-pm@vger.kernel.org,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Javi Merino <javi.merino@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering
Date: Fri, 12 Mar 2021 10:58:18 +0000 [thread overview]
Message-ID: <452c1619-fcda-d006-721a-d471389aa90a@arm.com> (raw)
In-Reply-To: <20210310114600.27178-1-daniel.lezcano@linaro.org>
Hi Daniel,
Only minor comments.
On 3/10/21 11:45 AM, Daniel Lezcano wrote:
> Currently the naming of a cooling device is just a cooling technique
> followed by a number. When there are multiple cooling devices using
> the same technique, it is impossible to clearly identify the related
> device as this one is just a number.
>
> For instance:
>
> thermal-cpufreq-0
> thermal-cpufreq-1
> etc ...
>
> The 'thermal' prefix is redundant with the subsystem namespace. This
> patch removes the 'thermal prefix and changes the number by the device
missing ', after 'thermal
> name. So the naming above becomes:
>
> cpufreq-cpu0
> cpufreq-cpu4
> etc ...
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/cpufreq_cooling.c | 28 +++++++---------------------
> 1 file changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
> index 10af3341e5ea..cf0332bbdcd3 100644
> --- a/drivers/thermal/cpufreq_cooling.c
> +++ b/drivers/thermal/cpufreq_cooling.c
> @@ -13,6 +13,7 @@
> #include <linux/cpu.h>
> #include <linux/cpufreq.h>
> #include <linux/cpu_cooling.h>
> +#include <linux/device.h>
> #include <linux/energy_model.h>
> #include <linux/err.h>
> #include <linux/export.h>
You can now also remove the header:
#include <linux/idr.h>
other than that, LGTM
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
prev parent reply other threads:[~2021-03-12 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 11:45 [PATCH 1/3] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering Daniel Lezcano
2021-03-10 11:45 ` [PATCH 2/3] thermal/drivers/devfreq_cooling: " Daniel Lezcano
2021-03-12 11:15 ` Lukasz Luba
2021-03-12 15:53 ` Daniel Lezcano
2021-03-10 11:46 ` [PATCH 3/3] thermal/drivers/cpuidle_cooling: " Daniel Lezcano
2021-03-12 11:34 ` Lukasz Luba
2021-03-12 5:10 ` [PATCH 1/3] thermal/drivers/cpufreq_cooling: " Viresh Kumar
2021-03-12 10:58 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452c1619-fcda-d006-721a-d471389aa90a@arm.com \
--to=lukasz.luba@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.