Re: [PATCH v5] status: long status advice adapted to recent capabilities

From: Jeff Hostetler <git@jeffhostetler.com>
To: Rudy Rigot via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: "Taylor Blau" <me@ttaylorr.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Derrick Stolee" <derrickstolee@github.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Rudy Rigot" <rudy.rigot@gmail.com>
Subject: Re: [PATCH v5] status: long status advice adapted to recent capabilities
Date: Tue, 15 Nov 2022 11:39:47 -0500	[thread overview]
Message-ID: <454089ac-3d0d-9820-26a4-e5650c2604d2@jeffhostetler.com> (raw)
In-Reply-To: <pull.1384.v5.git.1668110679098.gitgitgadget@gmail.com>

On 11/10/22 3:04 PM, Rudy Rigot via GitGitGadget wrote:
> From: Rudy Rigot <rudy.rigot@gmail.com>
> 
> Improve the advice displayed when `git status` is slow because
> of excessive numbers of untracked files.  Update the `git status`
> man page to explain the various configuration options.
> 
> `git status` can be slow when there are a large number of untracked
> files and directories, because Git must search the entire worktree
> to enumerate them.  Previously, Git would print an advice message
> with the elapsed search time and a suggestion to disable the search
> using the `-uno` option.  This suggestion also carried a warning
> that might scare off some users.
> 
> Git can reduce the size and time of the untracked file search when
> the `core.untrackedCache` and `core.fsmonitor` features are enabled
> by caching results from previous `git status` invocations.
> 
> Update the advice to explain the various combinations of additional
> configuration options and refer to (new) documentation in the man
> page that explains it in more detail than what can be printed in an
> advice message.
> 
> Finally, add new tests to verify the new functionality.
> 
> Signed-off-by: Rudy Rigot <rudy.rigot@gmail.com>

I think V5 looks good.
Thanks for your persistence!

Jeff