Re: [PATCH v2 3/4] hwmon: (it87) Add calls to smbus_enable/smbus_disable as required

From: Guenter Roeck <linux@roeck-us.net>
To: Frank Crawford <frank@crawford.emu.id.au>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 3/4] hwmon: (it87) Add calls to smbus_enable/smbus_disable as required
Date: Sun, 16 Apr 2023 07:51:08 -0700	[thread overview]
Message-ID: <45592027-c117-478e-81e1-42b71a186b37@roeck-us.net> (raw)

On Sun, Apr 16, 2023 at 02:25:09PM +1000, Frank Crawford wrote:
> Disable/re-enable access through SMBus for chip registers when they are
> are being read or written.
> 
> For simple cases this is done at the same time as when a mutex is set,
> however, within loops or during initialisation it is done separately.
> 
> Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>

Nit:

CHECK: Alignment should match open parenthesis
#527: FILE: drivers/hwmon/it87.c:3316:
+	if ((it87_read_value(data, IT87_REG_CONFIG) & 0x80) ||
+			     it87_read_value(data, IT87_REG_CHIPID) != 0x90) {

No need to resend, I fixed it up. Applied.

Thanks,
Guenter