From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
George Dunlap <George.Dunlap@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/rwlock: Don't perpeuatite broken API in new logic
Date: Wed, 20 Mar 2024 09:31:25 +0100 [thread overview]
Message-ID: <45ab1427-dc17-4881-9941-6372d2e23107@suse.com> (raw)
In-Reply-To: <20240319113020.3843309-1-andrew.cooper3@citrix.com>
On 19.03.2024 12:30, Andrew Cooper wrote:
> The single user wants this the sane way around. Write it as a normal static
> inline just like rspin_lock().
>
> Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Notwithstanding Jürgen's R-b I'd be quite a bit happier if (a) this and
spin_lock_irqsave() remained consistent with one another or at least
(b) the implications of doing the necessary transformation for the
latter towards Linux compatibility were visible to have been considered,
in particular with it in mind that Misra won't like
#define spin_lock_irqsave(l, f) \
({ \
BUILD_BUG_ON(sizeof(f) != sizeof(unsigned long)); \
(f) = spin_lock_irqsave(l); \
})
in linux-compat.h (and obviously with xen/spinlock.h included ahead of
this).
Jan
prev parent reply other threads:[~2024-03-20 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 11:30 [PATCH] xen/rwlock: Don't perpeuatite broken API in new logic Andrew Cooper
2024-03-20 6:35 ` Jürgen Groß
2024-03-20 8:56 ` Julien Grall
2024-03-20 8:31 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ab1427-dc17-4881-9941-6372d2e23107@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.