From: Michael Hennerich <michael.hennerich@analog.com>
To: Stefan Schmidt <stefan@osg.samsung.com>, linux-wpan@vger.kernel.org
Cc: Alexander Aring <aring@mojatatu.com>,
h.morris@cascoda.com, linuxdev@cascoda.com,
varkabhadram@gmail.com, alan@signal11.us
Subject: Re: [PATCH 01/14] ieee802154: adf7242: use unsigned int over only unsigned
Date: Mon, 6 Nov 2017 16:37:07 +0100 [thread overview]
Message-ID: <45c7b95b-fff6-aef6-eae6-b82e957cdf91@analog.com> (raw)
In-Reply-To: <20170922121405.31789-2-stefan@osg.samsung.com>
On 22.09.2017 14:13, Stefan Schmidt wrote:
> Bring it in line with the rest of the ieee802154 drivers.
> Found by checkpatch.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/net/ieee802154/adf7242.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
> index 3e4c8b21403c..400fdbd3a120 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -311,8 +311,8 @@ static int adf7242_status(struct adf7242_local *lp, u8 *stat)
> return status;
> }
>
> -static int adf7242_wait_status(struct adf7242_local *lp, unsigned status,
> - unsigned mask, int line)
> +static int adf7242_wait_status(struct adf7242_local *lp, unsigned int status,
> + unsigned int mask, int line)
> {
> int cnt = 0, ret = 0;
> u8 stat;
> @@ -477,7 +477,7 @@ static int adf7242_write_reg(struct adf7242_local *lp, u16 addr, u8 data)
> return status;
> }
>
> -static int adf7242_cmd(struct adf7242_local *lp, unsigned cmd)
> +static int adf7242_cmd(struct adf7242_local *lp, unsigned int cmd)
> {
> int status;
>
> @@ -920,7 +920,7 @@ static void adf7242_debug(u8 irq1)
> static irqreturn_t adf7242_isr(int irq, void *data)
> {
> struct adf7242_local *lp = data;
> - unsigned xmit;
> + unsigned int xmit;
> u8 irq1;
>
> adf7242_wait_status(lp, RC_STATUS_PHY_RDY, RC_STATUS_MASK, __LINE__);
>
--
Greetings,
Michael
--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne
next prev parent reply other threads:[~2017-11-06 15:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 12:13 [PATCH 00/14] Checkpatch cleanup for ieee802154 drivers Stefan Schmidt
2017-09-22 12:13 ` [PATCH 01/14] ieee802154: adf7242: use unsigned int over only unsigned Stefan Schmidt
2017-11-06 15:37 ` Michael Hennerich [this message]
2017-11-06 15:39 ` Stefan Schmidt
2017-09-22 12:13 ` [PATCH 02/14] ieee802154: at86rf230: switch from BUG_ON() to WARN_ON() on problem Stefan Schmidt
2017-09-22 12:13 ` [PATCH 03/14] ieee802154: at86rf230: use __func__ macro for debug messages Stefan Schmidt
2017-09-22 12:13 ` [PATCH 04/14] ieee802154: atusb: switch from uint8_t to u8 Stefan Schmidt
2017-11-06 15:35 ` Stefan Schmidt
2017-09-22 12:13 ` [PATCH 05/14] ieee802154: atusb: use __func__ macro for debug messages Stefan Schmidt
2017-11-06 15:35 ` Stefan Schmidt
2017-09-22 12:13 ` [PATCH 06/14] ieee802154: atusb: fix some kernel coding style errors Stefan Schmidt
2017-11-06 15:36 ` Stefan Schmidt
2017-09-22 12:13 ` [PATCH 07/14] ieee802154: atusb: switch from BUG_ON() to WARN_ON() on problem Stefan Schmidt
2017-11-06 15:36 ` Stefan Schmidt
2017-09-22 12:13 ` [PATCH 08/14] ieee802154: mrf24j40: fix some kernel coding style errors Stefan Schmidt
2017-09-22 14:12 ` Alan Ott
2017-09-22 14:38 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 09/14] ieee802154: ca8210: " Stefan Schmidt
2017-11-06 15:27 ` Harry Morris
2017-11-06 15:40 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 10/14] ieee802154: ca8210: use __func__ macro for debug messages Stefan Schmidt
2017-11-06 15:32 ` Harry Morris
2017-11-06 15:40 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 11/14] ieee802154: cc2520: fix some kernel coding style errors Stefan Schmidt
2017-11-06 15:34 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 12/14] ieee802154: cc2520: use __func__ macro for debug messages Stefan Schmidt
[not found] ` <CAEUmHyZ1oaMjqzMHgNtMg+S2cmq2DvvgAkxBsP6-dkzYp0KyOw@mail.gmail.com>
2017-11-06 15:23 ` Stefan Schmidt
2017-11-06 15:34 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 13/14] ieee802154: cc2520: switch from BUG_ON() to WARN_ON() on problem Stefan Schmidt
2017-11-06 15:32 ` Stefan Schmidt
2017-09-22 12:14 ` [PATCH 14/14] ieee802154: fakelb: " Stefan Schmidt
2017-11-06 14:25 ` [PATCH 00/14] Checkpatch cleanup for ieee802154 drivers Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c7b95b-fff6-aef6-eae6-b82e957cdf91@analog.com \
--to=michael.hennerich@analog.com \
--cc=alan@signal11.us \
--cc=aring@mojatatu.com \
--cc=h.morris@cascoda.com \
--cc=linux-wpan@vger.kernel.org \
--cc=linuxdev@cascoda.com \
--cc=stefan@osg.samsung.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.