From: Quentin Monnet <quentin@isovalent.com>
To: Song Liu <songliubraving@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: john.fastabend@gmail.com, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, arnaldo.melo@gmail.com, jolsa@kernel.org
Subject: Re: [PATCH v3 bpf-next 0/3] Fixes for bpftool-prog-profile
Date: Thu, 12 Mar 2020 18:29:26 +0000 [thread overview]
Message-ID: <461f01a8-1506-97c9-11db-4f1f1bad092b@isovalent.com> (raw)
In-Reply-To: <20200312182332.3953408-1-songliubraving@fb.com>
2020-03-12 11:23 UTC-0700 ~ Song Liu <songliubraving@fb.com>
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf;
> 3. Add files to .gitignore.
>
> Changes v2 => v3:
> 1. Add -I$(LIBBPF_PATH) to Makefile (Quentin);
> 2. Use p_err() for error message (Quentin).
>
> Changes v1 => v2:
> 1. Rewrite patch 1 with real feature detection (Quentin, Alexei).
> 2. Add files to .gitignore (Andrii).
>
> Song Liu (3):
> bpftool: only build bpftool-prog-profile if supported by clang
> bpftool: skeleton should depend on libbpf
> bpftool: add _bpftool and profiler.skel.h to .gitignore
>
> tools/bpf/bpftool/.gitignore | 2 ++
> tools/bpf/bpftool/Makefile | 20 +++++++++++++------
> tools/bpf/bpftool/prog.c | 1 +
> tools/build/feature/Makefile | 9 ++++++++-
> .../build/feature/test-clang-bpf-global-var.c | 4 ++++
> 5 files changed, 29 insertions(+), 7 deletions(-)
> create mode 100644 tools/build/feature/test-clang-bpf-global-var.c
>
> --
> 2.17.1
>
Series looks great, thank you!
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
next prev parent reply other threads:[~2020-03-12 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 18:23 [PATCH v3 bpf-next 0/3] Fixes for bpftool-prog-profile Song Liu
2020-03-12 18:23 ` [PATCH v3 bpf-next 1/3] bpftool: only build bpftool-prog-profile if supported by clang Song Liu
2020-03-12 18:23 ` [PATCH v3 bpf-next 2/3] bpftool: skeleton should depend on libbpf Song Liu
2020-03-12 18:23 ` [PATCH v3 bpf-next 3/3] bpftool: add _bpftool and profiler.skel.h to .gitignore Song Liu
2020-03-12 18:29 ` Quentin Monnet [this message]
2020-03-12 23:11 ` [PATCH v3 bpf-next 0/3] Fixes for bpftool-prog-profile Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461f01a8-1506-97c9-11db-4f1f1bad092b@isovalent.com \
--to=quentin@isovalent.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.