From: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 0/3] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq
Date: Thu, 11 Apr 2024 16:53:31 +0530 [thread overview]
Message-ID: <46c0d72d-d629-429b-94ec-d21f719db348@quicinc.com> (raw)
In-Reply-To: <5fc87d10b06f8b5b3024ac6c5674b18b.sboyd@kernel.org>
On 4/11/2024 10:31 AM, Stephen Boyd wrote:
> Quoting Kathiravan Thirumoorthy (2024-01-22 09:46:23)
>>
>>
>> On 12/21/2023 3:47 AM, Christian Marangi wrote:
>>> This small series fix a current problem with ipq8074 where the 2 uniphy
>>> port doesn't work in some corner case with some clk configuration. The
>>> port to correctly work require a specific frequency, using the wrong one
>>> results in the port not transmitting data.
>>>
>>> With the current code with a requested freq of 125MHz, the frequency is
>>> set to 105MHz. This is caused by the fact that there are 2 different
>>> configuration to set 125MHz and it's always selected the first one that
>>> results in 105MHz.
>>>
>>> In the original QSDK code, the frequency configuration selection is
>>> different and the CEIL FLOOR logic is not present. Instead it's used a
>>> BEST approach where the frequency table is checked and then it's checked
>>> if there are duplicate entry.
>>>
>>> This proposed implementation is more specific and introduce an entire new
>>> set of ops and a specific freq table to support this special configuration.
>>>
>>> A union is introduced in rcg2 struct to not duplicate the struct.
>>> A new set of ops clk_rcg2_fm_ops are introduced to support this new kind
>>> of frequency table.
>>>
>>
>>
>> Bjorn / Stephen Boyd,
>>
>> I would like to know if there are any comments on this series. To enable
>> the clocks required for the Ethernet interfaces on the IPQ platforms,
>> these patches are needed. If no concerns, can this be picked up for v6.9?
>>
>
> I'm fine if Bjorn wants to pick it up.
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
Thanks Stephen. Bjorn, can this series picked up for v6.10, if no
concerns from your side?
Thanks,
Kathiravan.
next prev parent reply other threads:[~2024-04-11 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 22:17 [PATCH v8 0/3] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq Christian Marangi
2023-12-20 22:17 ` [PATCH v8 1/3] clk: qcom: clk-rcg: " Christian Marangi
2023-12-20 22:17 ` [PATCH v8 2/3] clk: qcom: clk-rcg2: add support for rcg2 freq multi ops Christian Marangi
2023-12-20 22:17 ` [PATCH v8 3/3] clk: qcom: gcc-ipq8074: rework nss_port5/6 clock to multiple conf Christian Marangi
2024-01-22 17:46 ` [PATCH v8 0/3] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq Kathiravan Thirumoorthy
2024-04-11 5:01 ` Stephen Boyd
2024-04-11 11:23 ` Kathiravan Thirumoorthy [this message]
2024-04-27 19:34 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46c0d72d-d629-429b-94ec-d21f719db348@quicinc.com \
--to=quic_kathirav@quicinc.com \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.