Re: [Qemu-devel] [PATCH for-2.12] dump: Fix build with newer gcc

From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.12] dump: Fix build with newer gcc
Date: Tue, 3 Apr 2018 13:46:04 -0500	[thread overview]
Message-ID: <46f09a31-addb-32e0-d9b6-827166690a72@redhat.com> (raw)
In-Reply-To: <20180327202152.1799131-1-eblake@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On 03/27/2018 03:21 PM, Eric Blake wrote:
> gcc 8 on rawhide is picky enough to complain:
> 
> /home/dummy/qemu/dump.c: In function 'create_header32':
> /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length [-Werror=stringop-truncation]
>      strncpy(dh->signature, KDUMP_SIGNATURE, strlen(KDUMP_SIGNATURE));
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> But we already have SIG_LEN defined as the right length without needing
> to do a strlen(), and memcpy() is better than strncpy() when we know
> we do not want a trailing NUL byte.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  dump.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I'll include this in my qapi+misc pull request for 2.12-rc2

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]