From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Alex Elder <elder@linaro.org>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: andersson@kernel.org, agross@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, elder@kernel.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
Subject: Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support
Date: Thu, 8 Dec 2022 22:22:14 +0100 [thread overview]
Message-ID: <47b2fb29-1c2e-db6e-b14f-6dfe90341825@linaro.org> (raw)
In-Reply-To: <20221208211529.757669-3-elder@linaro.org>
On 8.12.2022 22:15, Alex Elder wrote:
> Add the necessary register and data definitions needed for IPA v4.7,
> which is found on the SM6350 SoC.
>
> Co-developed-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
[...]
> +
> +/* Memory configuration data for an SoC having IPA v4.7 */
> +static const struct ipa_mem_data ipa_mem_data = {
> + .local_count = ARRAY_SIZE(ipa_mem_local_data),
> + .local = ipa_mem_local_data,
> + .imem_addr = 0x146a9000,
> + .imem_size = 0x00002000,
Should probably be
0x146a8000
0x00003000
with an appropriate change in dt to reserve that region.
Qualcomm does:
ipa@... { qcom,additional-mapping = <0x146a8000 0x146a8000 0x2000>; };
which covers 0x146a8000-0x146a9fff
plus
imem@.. { reg = <0x146aa000 0x1000>; };
which in total gives us 0x146a8000-0x146aafff
That would also mean all of your writes are kind of skewed, unless
you already applied some offsets to them.
(IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per
the bootloader memory map)
Konrad
next prev parent reply other threads:[~2022-12-08 21:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 21:15 [PATCH net-next 0/2] net: ipa: enable IPA v4.7 support Alex Elder
2022-12-08 21:15 ` [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: Add SM6350 compatible Alex Elder
2022-12-09 8:24 ` Krzysztof Kozlowski
2022-12-30 20:50 ` Caleb Connolly
2022-12-08 21:15 ` [PATCH net-next 2/2] net: ipa: add IPA v4.7 support Alex Elder
2022-12-08 21:22 ` Konrad Dybcio [this message]
2022-12-09 20:22 ` Alex Elder
2022-12-10 9:31 ` Konrad Dybcio
2022-12-12 23:54 ` Jakub Kicinski
2022-12-13 1:11 ` Alex Elder
2022-12-30 17:28 ` Alex Elder
2022-12-30 23:53 ` Alex Elder
2022-12-13 0:00 ` [PATCH net-next 0/2] net: ipa: enable " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b2fb29-1c2e-db6e-b14f-6dfe90341825@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.