From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Joel Stanley" <joel@jms.id.au>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrzej Zaborowski" <balrogg@gmail.com>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Michael Walle" <michael@walle.cc>,
"Richard Henderson" <rth@twiddle.net>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Jason Wang" <jasowang@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Cédric Le Goater" <clg@kaod.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Rob Herring" <robh@kernel.org>
Subject: Re: [Qemu-devel] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header
Date: Mon, 7 Jan 2019 08:22:27 +0100 [thread overview]
Message-ID: <4821a853-bd25-7972-66dd-95092d216868@redhat.com> (raw)
In-Reply-To: <20190104175847.6290-10-philmd@redhat.com>
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Since uWireSlave is only used in this new header, there is no
> need to expose it via "qemu/typedefs.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> MAINTAINERS | 2 ++
> hw/arm/nseries.c | 2 +-
> hw/arm/palm.c | 2 +-
> hw/input/tsc2005.c | 2 +-
> hw/input/tsc210x.c | 4 ++--
> include/hw/arm/omap.h | 6 +-----
> include/hw/devices.h | 14 --------------
> include/hw/input/ti_uwire_tsc.h | 28 ++++++++++++++++++++++++++++
I'd maybe rather name the new file "tsc2xxx.h" instead, so that it
resembles the names of the .c files. Just my 0.02 €.
Thomas
next prev parent reply other threads:[~2019-01-07 7:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 17:58 [Qemu-devel] [PATCH 00/16] hw: Remove "hw/devices.h" Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 01/16] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string Philippe Mathieu-Daudé
2019-01-04 19:40 ` Thomas Huth
2019-01-07 6:48 ` Cédric Le Goater
2019-01-04 17:58 ` [Qemu-devel] [PATCH 02/16] hw: Remove unused 'hw/devices.h' include Philippe Mathieu-Daudé
2019-01-04 22:24 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2019-01-07 9:56 ` [Qemu-devel] " Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition Philippe Mathieu-Daudé
2019-01-07 6:32 ` Thomas Huth
2019-01-07 7:56 ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 04/16] hw/devices: Move TC6393XB declarations into a new header Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 05/16] hw/devices: Move Blizzard " Philippe Mathieu-Daudé
2019-01-07 6:39 ` Thomas Huth
2019-01-07 7:58 ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 06/16] hw/devices: Move CBus " Philippe Mathieu-Daudé
2019-01-07 7:00 ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 07/16] hw/devices: Move Gamepad " Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices Philippe Mathieu-Daudé
2019-01-07 7:18 ` Thomas Huth
2019-01-07 8:02 ` Philippe Mathieu-Daudé
2019-01-07 8:05 ` Thomas Huth
2019-01-07 11:44 ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header Philippe Mathieu-Daudé
2019-01-07 7:22 ` Thomas Huth [this message]
2019-01-07 8:02 ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 10/16] typedefs: Remove MouseTransformInfo Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 11/16] typedefs: Remove PS2State Philippe Mathieu-Daudé
2019-01-07 7:26 ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header Philippe Mathieu-Daudé
2019-01-07 7:29 ` Thomas Huth
2019-01-07 8:04 ` Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header Philippe Mathieu-Daudé
2019-01-07 7:34 ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 14/16] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string Philippe Mathieu-Daudé
2019-01-04 17:58 ` [Qemu-devel] [PATCH 15/16] hw/devices: Move SMSC 91C111 declaration into a new header Philippe Mathieu-Daudé
2019-01-07 7:38 ` Thomas Huth
2019-01-04 17:58 ` [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function Philippe Mathieu-Daudé
2019-01-04 19:35 ` Thomas Huth
2019-02-04 23:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4821a853-bd25-7972-66dd-95092d216868@redhat.com \
--to=thuth@redhat.com \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=balrogg@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.