From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] lockprof: don't leave locks uninitialized upon allocation failure
Date: Thu, 23 Jul 2020 13:26:36 +0200 [thread overview]
Message-ID: <48417b2c-2d09-a63f-f300-8eb725339285@suse.com> (raw)
In-Reply-To: <39e8063c-3e91-fb27-1160-13baa0a97849@citrix.com>
On 23.07.2020 13:23, Andrew Cooper wrote:
> On 23/07/2020 11:51, Jan Beulich wrote:
>> Even if a specific struct lock_profile instance can't be allocated, the
>> lock itself should still be functional. As this isn't a production use
>> feature, also log a message in the event that the profiling struct can't
>> be allocated.
>>
>> Fixes: d98feda5c756 ("Make lock profiling usable again")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/include/xen/spinlock.h
>> +++ b/xen/include/xen/spinlock.h
>> @@ -103,10 +103,16 @@ struct lock_profile_qhead {
>> do { \
>> struct lock_profile *prof; \
>> prof = xzalloc(struct lock_profile); \
>> - if (!prof) break; \
>> + (s)->l = (spinlock_t)_SPIN_LOCK_UNLOCKED(prof); \
>> + if ( !prof ) \
>> + { \
>> + printk(XENLOG_WARNING \
>> + "lock profiling unavailable for %p(%d)'s " #l "\n", \
>> + s, (s)->profile_head.idx); \
>
> You'll end up with far less .rodata if you use %s and pass #l in as a
> parameter.
Well, "far less" perhaps goes a little far, as we currently have
just three use sites, but I see your point and hence will switch.
> Either way, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks, Jan
next prev parent reply other threads:[~2020-07-23 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 10:50 [PATCH 0/2] lockprof: eliminate a minor bug and a quirk Jan Beulich
2020-07-23 10:51 ` [PATCH 1/2] lockprof: don't leave locks uninitialized upon allocation failure Jan Beulich
2020-07-23 11:23 ` Andrew Cooper
2020-07-23 11:26 ` Jan Beulich [this message]
2020-07-23 10:52 ` [PATCH 2/2] lockprof: don't pass name into registration function Jan Beulich
2020-07-23 11:27 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48417b2c-2d09-a63f-f300-8eb725339285@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.