Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirkforLenovo A630Z TIO built-in usb-audio card - Kai-Heng Feng

From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: 彭浩 <penghao@uniontech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	johan <johan@kernel.org>, jonathan <jonathan@jdcox.net>,
	tomasz <tomasz@meresinski.eu>,
	Hans de Goede <hdegoede@redhat.com>, dlaz <dlaz@chromium.org>,
	"richard.o.dodd" <richard.o.dodd@gmail.com>,
	kerneldev <kerneldev@karsmulder.nl>,
	linux-usb <linux-usb@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirkforLenovo A630Z TIO built-in usb-audio card
Date: Tue, 24 Nov 2020 20:57:07 +0800	[thread overview]
Message-ID: <484458B3-EADF-48AC-94E0-13C3247783DA@canonical.com> (raw)
In-Reply-To: <1503654237.281102.1605875117132.JavaMail.xmail@bj-wm-cp-6>

Hi penghao,

> On Nov 20, 2020, at 20:25, 彭浩 <penghao@uniontech.com> wrote:
> 
> 
> > Seeking a better fix, we've tried a lot of things, including:
> > - Check that the device's power/wakeup is disabled
> > - Check that remote wakeup is off at the USB level
> > - All the quirks in drivers/usb/core/quirks.c
> Since the machine has been returned to the manufacturer, i can not provide dynamic debugging information.
> Is there any other way to solve your doubts？

Basically, no.

It would be great if we can know whether the device is quiesced in U3 before suspend.
Currently xHCI doesn't poll for U3 for global suspend.

Kai-Heng

> 
> peng hao 
> 
> 统信软件技术有限公司
> 
> UnionTech Software Technology Co., Ltd. 　
> 
> 官网：www.uniontech.com　　
> 
> 
> 
> 此电子邮件消息仅供预期收件人使用，其中可能包含保密或特权使用信息。如果您不是预期收件人，请勿使用、传播、分发或复制此电子邮件或信赖此邮件采取任何行动。如果您误收了此邮件，请立即回复邮件通知统信软件技术有限公司发件人，并删除误收电子邮件及其相关附件。感谢配合！
> 
> This email message is intended only for the use of the individual or entity who/which is the intended recipient and may contain information that is privileged or confidential. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of, or taking any action in reliance on, this e-mail is strictly prohibited. If you have received this email in error, please notify UnionTech Software Technology  immediately by replying to this e-mail and immediately delete and discard all copies of the e-mail and the attachment thereto (if any). Thank you.
> 
> 
> 
> 
> ----- Original Message -----
> From:Kai-Heng Feng <kai.heng.feng@canonical.com> 
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>  
> CC: 彭浩 <penghao@uniontech.com> johan <johan@kernel.org> jonathan <jonathan@jdcox.net> tomasz <tomasz@meresinski.eu> Hans de Goede <hdegoede@redhat.com> dlaz <dlaz@chromium.org> richard.o.dodd <richard.o.dodd@gmail.com> kerneldev <kerneldev@karsmulder.nl> linux-usb <linux-usb@vger.kernel.org> linux-kernel <linux-kernel@vger.kernel.org>  
> Sent: 2020-11-20 02:27
> Subject: Re:Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirkforLenovo A630Z TIO built-in usb-audio card
> 
> 
> 
> > On Nov 19, 2020, at 22:23, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Thu, Nov 19, 2020 at 10:12:02PM +0800, Kai-Heng Feng wrote:
> >> 
> >> 
> >>> On Nov 19, 2020, at 21:59, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>> 
> >>> On Thu, Nov 19, 2020 at 09:41:32PM +0800, Kai-Heng Feng wrote:
> >>>> Hi penghao,
> >>>> 
> >>>>> On Nov 19, 2020, at 20:17, 彭浩 <penghao@uniontech.com> wrote:
> >>>>> 
> >>>>> root@uos-PC:/sys/bus/usb/devices/usb7# dmesg
> >>>>> [ 0.000000] Linux version 4.19.0-6-amd64 (debian-kernel@lists.debian.org) (gcc version 8.3.0 (Debian 8.3.0-6)) #1 SMP Uos 4.19.67-11eagle (2020-03-21)
> >>>> 
> >>>> Thanks for the dmesg. But would it be possible to use mainline kernel enable dynamic debug?
> >>>> 
> >>>> But anyway, this is not a regular AMD or Intel platform, so I guess we can merge the quirk as is...
> >>>> 
> >>>> Kai-Heng
> >>>> 
> >>>>> [ 0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-4.19.0-6-amd64 root=UUID=e5a40c4f-d88e-4a4d-9414-a27892a31be7 ro splash console=ttyS0,115200n8 loglevel=7 DEEPIN_GFXMODE=0,1920x1080,1600x1200,1280x1024,1024x768
> >>>>> [ 0.000000] Zhaoxin Linux Patch Version is V3.0.2 
> >>>>> [ 0.000000] With Zhaoxin Shanghai CPU patch V2.0.0
> >>> 
> >>> What do you mean "not a regular"? This is an x86-variant chip platform,
> >>> but what does that have to do with the USB quirk detection?
> >> 
> >> USB quirk detection should work fine. I was trying to find the root cause, but seeing it's a Zhaoxin CPU, that could be the reason why mainline kernel, which has many USB power management fixes, wasn't used.
> >> 
> >> penghao, is it possible to boot mainline kernel on Zhaoxin CPU?
> > 
> > There have been a number of small patches for this type of CPU merged
> > over the past months, so I hope a mainline kernel works here :)
> > 
> > That being said, why would the platform matter for a USB device quirk?
> 
> No, it doesn't matter at all. 
> Because I am not sure if it can boot a mainline kernel, and the author doesn't know how to enable dynamic debug to let us understand what really happens here.
> 
> Kai-Hen
> 
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> 