From: Eric Snowberg <eric.snowberg@oracle.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: "linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Raul Rangel <rrangel@chromium.org>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v3] ima: detect changes to the backing overlay file
Date: Wed, 25 Oct 2023 16:27:52 +0000 [thread overview]
Message-ID: <485C9C57-ABF1-4618-81D1-345597A1B9FA@oracle.com> (raw)
In-Reply-To: <20231025143906.133218-1-zohar@linux.ibm.com>
> On Oct 25, 2023, at 8:39 AM, Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> Commit 18b44bc5a672 ("ovl: Always reevaluate the file signature for
> IMA") forced signature re-evaulation on every file access.
>
> Instead of always re-evaluating the file's integrity, detect a change
> to the backing file, by comparing the cached file metadata with the
> backing file's metadata. Verifying just the i_version has not changed
> is insufficient. In addition save and compare the i_ino and s_dev
> as well.
>
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
I ran the file integrity tests that originally uncovered the need for
"Commit 18b44bc5a672 ("ovl: Always reevaluate the file signature for
IMA”). When the backing file is changed, file integrity remains. For that
part, feel free to add:
Tested-by: Eric Snowberg <eric.snowberg@oracle.com>
next prev parent reply other threads:[~2023-10-25 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 14:39 [PATCH v3] ima: detect changes to the backing overlay file Mimi Zohar
2023-10-25 14:59 ` Raul Rangel
2023-10-25 15:09 ` Mimi Zohar
2023-10-25 16:27 ` Eric Snowberg [this message]
2023-10-25 18:01 ` Mimi Zohar
2023-10-26 15:31 ` Raul Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485C9C57-ABF1-4618-81D1-345597A1B9FA@oracle.com \
--to=eric.snowberg@oracle.com \
--cc=amir73il@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.