From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Roland Dreier <roland@purestorage.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/qib: remove superfluous fallthrough statements
Date: Tue, 25 Aug 2020 11:19:18 -0500 [thread overview]
Message-ID: <4877c3a5-365e-4500-43c0-4a4361e2cda3@embeddedor.com> (raw)
In-Reply-To: <20200825155142.349651-1-alex.dewar90@gmail.com>
On 8/25/20 10:51, Alex Dewar wrote:
> Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
> were later converted to fallthrough statements by commit df561f6688fe
> ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity
> warning about unreachable code.
>
> Remove the fallthrough statements and replace the mass of gotos with
> simple return statements to make the code terser and less bug-prone.
>
This should be split up into two separate patches: one to address the
fallthrough markings, and another one for the gotos.
Thanks
--
Gustavo
next prev parent reply other threads:[~2020-08-25 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:51 [PATCH] IB/qib: remove superfluous fallthrough statements Alex Dewar
2020-08-25 16:19 ` Gustavo A. R. Silva [this message]
2020-08-25 16:26 ` Joe Perches
2020-08-25 16:49 ` Gustavo A. R. Silva
2020-08-25 16:47 ` Joe Perches
2020-08-25 17:01 ` Gustavo A. R. Silva
2020-08-25 20:55 ` Joe Perches
2020-08-25 16:58 ` Alex Dewar
2020-08-25 17:12 ` [PATCH v2 1/2] " Alex Dewar
2020-08-25 19:33 ` Gustavo A. R. Silva
2020-08-26 19:18 ` Gustavo A. R. Silva
2020-08-27 0:11 ` Jason Gunthorpe
2020-08-27 1:41 ` Gustavo A. R. Silva
2020-08-27 10:40 ` Alex Dewar
2020-08-31 16:25 ` Jason Gunthorpe
2020-08-25 17:12 ` [PATCH v2 2/2] IB/qib: tidy up process_cc() Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4877c3a5-365e-4500-43c0-4a4361e2cda3@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=alex.dewar90@gmail.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.