From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Clement Courbet <courbet@google.com>,
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
clang-built-linux@googlegroups.com,
Paul Mackerras <paulus@samba.org>,
Clement Courbet <courbet@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3] powerpc: Make setjmp/longjmp signature standard
Date: Wed, 1 Apr 2020 23:53:38 +1100 (AEDT) [thread overview]
Message-ID: <48smN34DHnz9sTd@ozlabs.org> (raw)
In-Reply-To: <20200330080400.124803-1-courbet@google.com>
On Mon, 2020-03-30 at 08:03:56 UTC, Clement Courbet wrote:
> Declaring setjmp()/longjmp() as taking longs makes the signature
> non-standard, and makes clang complain. In the past, this has been
> worked around by adding -ffreestanding to the compile flags.
>
> The implementation looks like it only ever propagates the value
> (in longjmp) or sets it to 1 (in setjmp), and we only call longjmp
> with integer parameters.
>
> This allows removing -ffreestanding from the compilation flags.
>
> Context:
> https://lore.kernel.org/patchwork/patch/1214060
> https://lore.kernel.org/patchwork/patch/1216174
>
> Signed-off-by: Clement Courbet <courbet@google.com>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> Tested-by: Nathan Chancellor <natechancellor@gmail.com>
> Cc: stable@vger.kernel.org # v4.14+
> Fixes: c9029ef9c957 ("powerpc: Avoid clang warnings around setjmp and longjmp")
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c17eb4dca5a353a9dbbb8ad6934fe57af7165e91
cheers
prev parent reply other threads:[~2020-04-01 13:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:07 [PATCH v1] powerpc: Make setjmp/longjump signature standard Clement Courbet
2020-03-27 10:07 ` Clement Courbet
2020-03-27 17:10 ` Nick Desaulniers
2020-03-27 17:10 ` Nick Desaulniers
2020-03-27 17:27 ` Nathan Chancellor
2020-03-27 17:27 ` Nathan Chancellor
2020-03-27 17:45 ` Christophe Leroy
2020-03-27 17:45 ` Christophe Leroy
2020-03-27 18:27 ` Nathan Chancellor
2020-03-27 18:27 ` Nathan Chancellor
2020-03-30 6:42 ` Clement Courbet
2020-03-30 6:42 ` Clement Courbet
2020-03-30 6:43 ` [PATCH v2] powerpc: Make setjmp/longjmp " Clement Courbet
2020-03-30 6:43 ` Clement Courbet
2020-03-30 7:57 ` Nathan Chancellor
2020-03-30 7:57 ` Nathan Chancellor
2020-03-30 8:03 ` [PATCH v3] " Clement Courbet
2020-03-30 8:03 ` Clement Courbet
2020-03-30 16:20 ` Nick Desaulniers
2020-03-30 16:20 ` Nick Desaulniers
2020-03-31 13:11 ` Sasha Levin
2020-03-31 16:00 ` Nick Desaulniers
2020-04-01 12:53 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48smN34DHnz9sTd@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=clang-built-linux@googlegroups.com \
--cc=courbet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.