From: Jens Axboe <axboe@kernel.dk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, tim@cyberelk.net
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] paride: fix up build warning on mips platforms
Date: Mon, 20 Dec 2021 09:33:12 -0700 [thread overview]
Message-ID: <4915ba81-28b1-6008-62f2-50316177fd46@kernel.dk> (raw)
In-Reply-To: <YcCo8+jTG3b+5GTA@kroah.com>
On 12/20/21 9:01 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 30, 2021 at 09:46:26AM +0100, Greg Kroah-Hartman wrote:
>> MIPS include files define "PC" so when building the paride driver the
>> following build warning shows up:
>>
>> rivers/block/paride/bpck.c:32: warning: "PC" redefined
>>
>> Fix this by undefining PC before redefining it as is done for other
>> defines in this driver.
>>
>> Cc: Tim Waugh <tim@cyberelk.net>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-block@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>> drivers/block/paride/bpck.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/paride/bpck.c b/drivers/block/paride/bpck.c
>> index f5f63ca2889d..d880a9465e9b 100644
>> --- a/drivers/block/paride/bpck.c
>> +++ b/drivers/block/paride/bpck.c
>> @@ -28,6 +28,7 @@
>>
>> #undef r2
>> #undef w2
>> +#undef PC
>>
>> #define PC pi->private
>> #define r2() (PC=(in_p(2) & 0xff))
>> --
>> 2.34.1
>>
>
> Given the lack of objections to this, I'll just take it through one of
> my trees for 5.17-rc1.
Sorry about that, got lost. I can queue it up too, or you can add my
acked-by, either is fine.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-20 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:46 [PATCH] paride: fix up build warning on mips platforms Greg Kroah-Hartman
2021-12-20 16:01 ` Greg Kroah-Hartman
2021-12-20 16:33 ` Jens Axboe [this message]
2021-12-21 9:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4915ba81-28b1-6008-62f2-50316177fd46@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.