From: Avi Kivity <avi@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix typos and whitespace errors
Date: Wed, 14 Jan 2009 16:55:40 +0200 [thread overview]
Message-ID: <496DFCEC.7080509@redhat.com> (raw)
In-Reply-To: <20090113105305.GB28504@amit-x200.pnq.redhat.com>
Amit Shah wrote:
>> -#define KVM_CPUID_FLAG_SIGNIFCANT_INDEX 1
>> -#define KVM_CPUID_FLAG_STATEFUL_FUNC 2
>> -#define KVM_CPUID_FLAG_STATE_READ_NEXT 4
>> +#define KVM_CPUID_FLAG_SIGNIFICANT_INDEX 1
>>
>
> Avi, this is assuming we can push this fix to the stable kernel series.
> Can that be done or should we live with the typo? (Or adding a
> #define KVM_CPUID_FLAG_SIGNIFICANT_INDEX KVM_CPUID_FLAG_SIGNIFCANT_INDEX
> ?)
>
I think we can live with the typo. We have enough compatibility headaches.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-01-14 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 10:47 Support for cpuid functions with subleaves Amit Shah
2009-01-13 10:47 ` [PATCH] KVM: x86: Fix typos and whitespace errors Amit Shah
2009-01-13 10:47 ` [PATCH 1/2] kvm: libkvm: Add a wrapper for an ioctl for the KVM_SET_CPUID2 interface Amit Shah
2009-01-13 10:47 ` [PATCH 2/2] KVM: userspace: Fetch sub-leaf cpuid values for functions 4, 0xb, 0xd Amit Shah
2009-01-14 14:57 ` Avi Kivity
2009-01-14 14:52 ` [PATCH 1/2] kvm: libkvm: Add a wrapper for an ioctl for the KVM_SET_CPUID2 interface Avi Kivity
2009-01-13 10:53 ` [PATCH] KVM: x86: Fix typos and whitespace errors Amit Shah
2009-01-14 14:55 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-14 16:56 Amit Shah
2009-01-15 9:37 ` Avi Kivity
2009-01-12 10:49 CPUID handling: cleanups and support for storing subleaf values Amit Shah
2009-01-12 10:49 ` [PATCH] KVM: x86: Fix typos and whitespace errors Amit Shah
2009-01-11 16:19 Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496DFCEC.7080509@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.