From: Greg Ungerer <gerg@snapgear.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: torvalds@linux-foundation.org, arnd@arndb.de, gerg@uclinux.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-m68k@vger.kernel.org, sam@ravnborg.org,
uclinux-dev@uclinux.org, zippel@linux-m68k.org
Subject: Re: [git pull] m68k and m68knommu merge of includes
Date: Wed, 21 Jan 2009 13:38:58 +1000 [thread overview]
Message-ID: <497698D2.1050804@snapgear.com> (raw)
In-Reply-To: <1232502275.5653.2.camel@brick>
Hi Harvey,
Harvey Harrison wrote:
> On Wed, 2009-01-21 at 10:58 +1000, Greg Ungerer wrote:
>> Hi Linus,
>>
>> Please consider pulling this merge of the m68k and m68knommu include files.
>> It comepletely moves include/asm-m68k to arch/m68k/include as part of the
>> process, and ultimately results in both m68k and m68knommu arch code using
>> the same set of includes. More cleanup can follow, but this is the
>> necessary first step.
>>
>> Thanks
>> Greg
>
> I think you need to check your arch/m68k/include/asm/swab.h as I get an
> empty file when I pull this. It looks like it needs a conditional
> include of swab_mm/swab_no similar to the other files.
Yes, something went wrong there...
> Also, because of the byteorder changes, it looks like you don't need
> a separate byteorder_mm/no as they both just include the generic
> include/linux/byteorder/big_endian.h
Are you happy to just apply your follow up patch to fix these issues,
after this has been pulled?
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2009-01-21 3:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 0:58 [git pull] m68k and m68knommu merge of includes Greg Ungerer
2009-01-21 1:44 ` Harvey Harrison
2009-01-21 1:50 ` [PATCH] m68k{nommu}: fixups after the header move Harvey Harrison
2009-01-21 3:38 ` Greg Ungerer [this message]
2009-01-21 3:49 ` [git pull] m68k and m68knommu merge of includes Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497698D2.1050804@snapgear.com \
--to=gerg@snapgear.com \
--cc=arnd@arndb.de \
--cc=gerg@uclinux.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dev@uclinux.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.