Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM

From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	p.zabel@pengutronix.de, geert+renesas@glider.be,
	magnus.damm@gmail.com, biju.das.jz@bp.renesas.com,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v6 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM
Date: Wed, 14 Feb 2024 17:51:27 +0200	[thread overview]
Message-ID: <497c4fb6-1ea1-4e14-bd43-ce4a4441694e@tuxon.dev> (raw)
In-Reply-To: <CAMuHMdU8iJhXWFTrVqr8W-ov2D=oSUbsyDP1kfs6mC3rBcLxzQ@mail.gmail.com>

Hi, Geert,

On 14.02.2024 17:26, Geert Uytterhoeven wrote:
> Hi Claudiu,
> 
> On Fri, Feb 9, 2024 at 1:25 PM claudiu beznea <claudiu.beznea@tuxon.dev> wrote:
>> On 08.02.2024 14:53, Geert Uytterhoeven wrote:
>>> On Thu, Feb 8, 2024 at 1:26 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>>
>>>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>>>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>>>> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>>>>
>>>> Suggested-by: Guenter Roeck <linux@roeck-us.net>
>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>> ---
>>>>
>>>> Changes in v6:
>>>> - update patch description
>>>> - fixed the dependency on COMPILE_TEST previously introduced
>>>
>>> Thanks for the update!
>>>
>>>> --- a/drivers/watchdog/Kconfig
>>>> +++ b/drivers/watchdog/Kconfig
>>>> @@ -911,6 +911,7 @@ config RENESAS_RZN1WDT
>>>>  config RENESAS_RZG2LWDT
>>>>         tristate "Renesas RZ/G2L WDT Watchdog"
>>>>         depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>>>> +       depends on PM
>>>
>>> depends on PM || COMPILE_TEST
>>
>> Isn't "depends on PM" enough? As of [1] ("If multiple dependencies are
>> defined, they are connected with '&&'") the above:
>>
>> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
>> depends on PM
>>
>> are translated into:
>> depends on (ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST) && PM
>>
>> Please let me know if I'm wrong.
> 
> That is correct.  But you still can compile-test this driver when
> compiling for a different platform, and CONFIG_PM is disabled.

Ok, I see, thank you!

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 