Re: [PATCH -v2] Add MCE support to KVM

From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Huang Ying <ying.huang@intel.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH -v2] Add MCE support to KVM
Date: Tue, 21 Apr 2009 19:21:27 +0300	[thread overview]
Message-ID: <49EDF287.9020908@redhat.com> (raw)
In-Reply-To: <49EDF057.9060501@codemonkey.ws>

Anthony Liguori wrote:
>
> Regardless of the KVM interface for this, to go upstream to QEMU, this 
> needs a TCG implementation which means the logic must be duplicated in 
> userspace.  In particular, this is because a user-visible command is 
> being introduced in the monitor.

Definitely.

>
> So Avi, regardless of what interface is chosen for KVM, can you hold 
> off applying these patches until there is a TCG implementation?  
> Otherwise, we'll be playing catchup between kvm-userspace and upstream 
> QEMU forever.

I have a feeling we will anyway, but that's no reason to increase the 
gap.  Huang, can you generate a version for qemu/tcg?

-- 
error compiling committee.c: too many arguments to function