From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH v2 4/6] x86: track when in #NMI context
Date: Tue, 18 Feb 2020 10:40:02 +0000 [thread overview]
Message-ID: <49a2df52-27fc-c6f2-f28c-03e913fb0331@citrix.com> (raw)
In-Reply-To: <20200217184324.73762-5-roger.pau@citrix.com>
On 17/02/2020 18:43, Roger Pau Monne wrote:
> Add helpers to track when running in #MC context. This is modeled
> after the in_irq helpers, but does not support reentry.
>
> Note that there are no users of in_mc() introduced by the change,
> further users will be added by followup changes.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
You probably mean s/mc/nmi/ throughout the commit message, but I'm
afraid these are rather problematic.
NMIs can be recursively entered, especially on corner cases in the crash
path. Asserting that the crash path is not recursive can lead to never
entering the crash kernel.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-18 10:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 18:43 [Xen-devel] [PATCH v2 0/6] x86: fixes/improvements for scratch cpumask Roger Pau Monne
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 1/6] x86/smp: unify header includes in smp.h Roger Pau Monne
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 2/6] x86: introduce a nmi_count tracking variable Roger Pau Monne
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 3/6] x86: track when in #MC context Roger Pau Monne
2020-02-17 19:29 ` Julien Grall
2020-02-18 9:45 ` Roger Pau Monné
2020-02-18 9:48 ` Roger Pau Monné
2020-02-18 11:20 ` Julien Grall
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 4/6] x86: track when in #NMI context Roger Pau Monne
2020-02-18 10:40 ` Andrew Cooper [this message]
2020-02-18 10:59 ` Roger Pau Monné
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 5/6] x86/smp: use a dedicated scratch cpumask in send_IPI_mask Roger Pau Monne
2020-02-18 10:53 ` Andrew Cooper
2020-02-18 11:10 ` Roger Pau Monné
2020-02-18 11:21 ` Andrew Cooper
2020-02-18 11:22 ` Roger Pau Monné
2020-02-18 11:35 ` Andrew Cooper
2020-02-18 11:46 ` Roger Pau Monné
2020-02-18 13:29 ` Andrew Cooper
2020-02-18 14:43 ` Roger Pau Monné
2020-02-18 15:34 ` Andrew Cooper
2020-02-18 15:40 ` Jan Beulich
2020-02-18 16:18 ` Roger Pau Monné
2020-02-18 16:33 ` Jan Beulich
2020-02-18 11:28 ` Jan Beulich
2020-02-18 11:44 ` Andrew Cooper
2020-02-17 18:43 ` [Xen-devel] [PATCH v2 6/6] x86: add accessors for scratch cpu mask Roger Pau Monne
2020-02-18 7:40 ` [Xen-devel] [PATCH v2 0/6] x86: fixes/improvements for scratch cpumask Jürgen Groß
2020-02-18 10:15 ` Roger Pau Monné
2020-02-18 10:46 ` Jürgen Groß
2020-02-18 10:26 ` Andrew Cooper
2020-02-18 10:54 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a2df52-27fc-c6f2-f28c-03e913fb0331@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.