Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs

From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, sheng.yang@intel.com
Subject: Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs
Date: Sun, 17 May 2009 23:49:31 +0300	[thread overview]
Message-ID: <4A10785B.8090906@redhat.com> (raw)
In-Reply-To: <1242217175.4786.50.camel@2710p.home>

Alex Williamson wrote:
> On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote:
>   
>> On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote:
>>     
>>> @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks,
>>>  	int fd;
>>>  	kvm_context_t kvm;
>>>  	int r;
>>> +#ifdef KVM_CAP_IRQ_ROUTING
>>>       
>> Let's kill all these ifdefs. Or at least, let's not add them.
>>     
>
> AFAICT, they're still used both for builds against older kernels and
> architectures that don't support it.  Hollis just added the one around
> kvm_get_irq_route_gsi() 10 days ago to fix ppc build.  Has it since been
> deprecated?  Thanks,
>   

They are somewhat documentary.  They used to be needed since we 
supported building against any kernel header, but aren't strictly needed 
now.  Let's keep them until we have Documentation/kvm/extensions.txt.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.