Re: [PATCH v2] qemu-kvm: x86: Refactor persistent CPU state

From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] qemu-kvm: x86: Refactor persistent CPU state
Date: Wed, 27 May 2009 12:48:26 +0300	[thread overview]
Message-ID: <4A1D0C6A.2070009@redhat.com> (raw)
In-Reply-To: <4A1A3F15.30809@web.de>

Jan Kiszka wrote:
>> Why are you using uint64_t?  It would be more natural to use ffsll and
>> the natural type of the bitmap vector.
>>     
>
> Better don't ask how I interpreted the ffs doc.
>   

It's a misdesigned API anyway.

>  
> +    if (version_id >= 9) {
> +        qemu_get_sbe32s(f, &pending_irq);
> +        memset(&env->interrupt_bitmap, 0, sizeof(env->interrupt_bitmap));
> +        if (pending_irq >= 0) {
> +            env->interrupt_bitmap[pending_irq / 64] |= 1 << (pending_irq % 64);
>   

(uint64_t)1 so we don't lose the upper word.

-- 
error compiling committee.c: too many arguments to function