Re: USB/DVB - Old Technotrend TT-connect S-2400 regression tracked down

From: David <david@unsolicited.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-media@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dbrownell@users.sourceforge.net, leonidv11@gmail.com,
	Greg KH <gregkh@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: USB/DVB - Old Technotrend TT-connect S-2400 regression tracked down
Date: Wed, 27 May 2009 19:42:59 +0100	[thread overview]
Message-ID: <4A1D89B3.2020400@unsolicited.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0905261646420.11998-100000@iolanthe.rowland.org>

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

Alan Stern wrote:
> On Mon, 25 May 2009, David wrote:
>
>   
> I think the idea of the patch was good, but the endpoint direction
> information got lost (because the information was taken from the dummy
> qTD which is always marked as OUT -- I don't see how this could ever
> have worked properly).  So let's redo it, using the new and proper
> interface for resetting endpoints.
>
> To tell the truth, I'm not entirely certain this will work either.  The 
> hardware may cache the endpoint state, so it may be necessary to unlink 
> the endpoint completely.  Still, try this version and see what happens.
>
> Alan Stern
>
>
>   
Sorry for the delay, your patch reached me just after I turned in last
night.

It looks good to me. dmesg is how I'd expect, and I've attached the usb
trace which looks pretty similar to when the original patch was reverted.

I'll test some more with some other peripherals & check that they work ok.

Thanks a lot!
David

[-- Attachment #2: patch2.log.bz2 --]
[-- Type: application/x-bzip, Size: 12603 bytes --]