Re: [PATCH 1/2] kvm: fix dirty bit tracking for slots with large pages

From: Avi Kivity <avi@redhat.com>
To: Izik Eidus <ieidus@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [PATCH 1/2] kvm: fix dirty bit tracking for slots with large pages
Date: Wed, 10 Jun 2009 14:54:00 +0300	[thread overview]
Message-ID: <4A2F9ED8.6010502@redhat.com> (raw)
In-Reply-To: <1244634691-9765-2-git-send-email-ieidus@redhat.com>

Izik Eidus wrote:
> When slot is already allocted and being asked to be tracked we need to break the
> large pages.
>
> This code flush the mmu when someone ask a slot to start dirty bit tracking.
>
> Signed-off-by: Izik Eidus <ieidus@redhat.com>
> ---
>  virt/kvm/kvm_main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 669eb4a..4a60c72 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1160,6 +1160,8 @@ int __kvm_set_memory_region(struct kvm *kvm,
>  			new.userspace_addr = mem->userspace_addr;
>  		else
>  			new.userspace_addr = 0;
> +
> +		kvm_arch_flush_shadow(kvm);
>  	}
>  	if (npages && !new.lpage_info) {
>  		largepages = 1 + (base_gfn + npages - 1) / KVM_PAGES_PER_HPAGE;
>   

Ryan, can you try this out with your large page migration failures?

-- 
error compiling committee.c: too many arguments to function