Re: [PATCH 2/4] cleanup mmio coalescing functions

From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 2/4] cleanup mmio coalescing functions
Date: Thu, 11 Jun 2009 12:19:29 +0300	[thread overview]
Message-ID: <4A30CC21.6000309@redhat.com> (raw)
In-Reply-To: <1244664293-9502-3-git-send-email-glommer@redhat.com>

Glauber Costa wrote:
> remove wrappers that existed only due to qemu/libkvm separation.
> Use qemu types for function definitions.
>
>  
> -int kvm_register_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size)
> +int kvm_coalesce_mmio_region(target_phys_addr_t addr, ram_addr_t size)
>  {
>  #ifdef KVM_CAP_COALESCED_MMIO
> +    kvm_context_t kvm = kvm_context;
>   

While all this code is doomed, please maintain consistent indentation 
while it lives.

>  	struct kvm_coalesced_mmio_zone zone;
>  	int r;
>  
> @@ -1121,9 +1122,10 @@ int kvm_register_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size)
>  	return -ENOSYS;
>  }
>  
> -int kvm_unregister_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size)
> +int kvm_uncoalesce_mmio_region(target_phys_addr_t addr, ram_addr_t size)
>  {
>  #ifdef KVM_CAP_COALESCED_MMIO
> +    kvm_context_t kvm = kvm_context;
>   

Here too.

-- 
error compiling committee.c: too many arguments to function