Re: [PATCH v5 6/6] VT-d: support the device IOTLB

From: Yu Zhao <yu.zhao@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH v5 6/6] VT-d: support the device IOTLB
Date: Mon, 29 Jun 2009 11:07:21 +0800	[thread overview]
Message-ID: <4A482FE9.5090503@intel.com> (raw)
In-Reply-To: <1246199317.663.578.camel@macbook.infradead.org>

David Woodhouse wrote:
> On Mon, 2009-05-18 at 13:51 +0800, Yu Zhao wrote:
>> @@ -965,6 +1037,8 @@ static void iommu_flush_iotlb_psi(struct intel_iommu *iommu, u16 did,
>>         else
>>                 iommu->flush.flush_iotlb(iommu, did, addr, mask,
>>                                                 DMA_TLB_PSI_FLUSH);
>> +       if (did)
>> +               iommu_flush_dev_iotlb(iommu->domains[did], addr, mask);
>>  }
>>  
>>  static void iommu_disable_protect_mem_regions(struct intel_iommu *iommu)
> 
> Hm, why 'if (did)' ? 
> 
> Domain ID zero is only special in caching mode. Should it be:
> 	if (!cap_caching_mode(iommu->cap) || did)
> ?

Yes, you are right. Domain ID 0 is only reserved for caching mode. Will 
send a fix for this.

Thanks!