Re: [KVM PATCH v8 3/3] KVM: create irqfd-cleanup-wq on demand

From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	mst@redhat.com, davidel@xmailserver.org
Subject: Re: [KVM PATCH v8 3/3] KVM: create irqfd-cleanup-wq on demand
Date: Thu, 02 Jul 2009 17:22:55 +0300	[thread overview]
Message-ID: <4A4CC2BF.3030809@redhat.com> (raw)
In-Reply-To: <20090701160913.3615.35388.stgit@dev.haskins.net>

On 07/01/2009 07:09 PM, Gregory Haskins wrote:
> We currently create this wq on module_init, which may be wasteful if the
> host never creates a guest that uses irqfd.  This patch changes the
> algorithm so that the workqueue is only created when at least one guest
> is using irqfd.  The queue is cleaned up when the last guest using irqfd
> is shutdown.
>
> To keep things simple, we only check whether the guest has tried to create
> an irqfd, not whether there are actually irqfds active.
>    

> +++ b/include/linux/kvm_host.h
> @@ -144,6 +144,7 @@ struct kvm {
>   	struct {
>   		spinlock_t        lock;
>   		struct list_head  items;
> +		int               init:1;
>    

Since you're rebasing anyway... change the bitfield to a bool.

-- 
error compiling committee.c: too many arguments to function