Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support

From: Gregory Haskins <ghaskins@novell.com>
To: Avi Kivity <avi@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [KVM PATCH v9 2/2] KVM: add iosignalfd support
Date: Tue, 07 Jul 2009 09:17:53 -0400	[thread overview]
Message-ID: <4A534B01.4020007@novell.com> (raw)
In-Reply-To: <4A53372E.6090509@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Avi Kivity wrote:
> (adding Davide, there's a small comment for you in the middle, search
> for eventfd)
>
> On 07/07/2009 02:20 PM, Michael S. Tsirkin wrote:
>>
>>> @@ -307,6 +307,19 @@ struct kvm_guest_debug {
>>>       struct kvm_guest_debug_arch arch;
>>>   };
>>>
>>> +#define KVM_IOSIGNALFD_FLAG_TRIGGER   (1<<  0) /* trigger is valid */
>>>      
>>
>> can we rename trigger ->  value?
>>    
>
> Or maybe data_match?

Yeah, at the least I should be consistent with trigger/match
>
> Speaking of renames, how about IOSIGNALFD -> IOEVENTFD?  I have some
> vague uneasiness seeing signals all the time.

Sure, that works for me.

-Greg

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]