From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6 v4] KVM support for 1GB pages
Date: Tue, 07 Jul 2009 20:04:55 +0300 [thread overview]
Message-ID: <4A538037.1010806@redhat.com> (raw)
In-Reply-To: <20090707165248.GR5380@amd.com>
On 07/07/2009 07:52 PM, Joerg Roedel wrote:
>> I would really like to have shadow 1GB work, or at least gain some
>> understanding of why it doesn't.
>>
>> Can you detail the changes compared to the previous round?
>>
>
> Until now I addressed the review comments from the previous round. The
> biggest change is patch #4 which was completly rewritten.
> I understand that it would be nicer to have shadow paging working too.
> But since most users will use this feature only on processors with
> nested paging (only processors with nested paging support gbpages) I
> don't think it should be a show-stopper. YMMV.
>
Right. I don't think 1GB+shadow is useful in its own right. It's not a
barrier for merging (but still very desirable). I do want more
information on how it fails though.
> Anyway, I will further try to get shadow paging support running and
> stable.
>
Great, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-07-07 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 16:41 [PATCH 0/6 v4] KVM support for 1GB pages Joerg Roedel
2009-07-07 16:41 ` [PATCH 1/6] kvm/mmu: make rmap code aware of mapping levels Joerg Roedel
2009-07-07 16:41 ` [PATCH 2/6] kvm/mmu: rename is_largepage_backed to mapping_level Joerg Roedel
2009-07-07 16:41 ` [PATCH 3/6] kvm/mmu: make direct mapping paths aware of mapping levels Joerg Roedel
2009-07-07 16:41 ` [PATCH 4/6] kvm/mmu: make page walker " Joerg Roedel
2009-07-07 16:41 ` [PATCH 5/6] kvm/mmu: enable gbpages by increasing nr of pagesizes Joerg Roedel
2009-07-07 16:41 ` [PATCH 6/6] kvm x86: report 1GB page support to userspace Joerg Roedel
2009-07-07 16:47 ` [PATCH 0/6 v4] KVM support for 1GB pages Avi Kivity
2009-07-07 16:52 ` Joerg Roedel
2009-07-07 17:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A538037.1010806@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.