From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix EPT identity IOCTL on 32pae
Date: Mon, 03 Aug 2009 15:25:43 +0300 [thread overview]
Message-ID: <4A76D747.2060506@redhat.com> (raw)
In-Reply-To: <1249280247-6732-1-git-send-email-sheng@linux.intel.com>
On 08/03/2009 09:17 AM, Sheng Yang wrote:
> Copy u64 from guest result in chaos.
>
> Also fix a mistake of still using old macro rather than new variable().
>
> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> arch/x86/kvm/x86.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 7931c72..c5aaa1b 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -2199,7 +2199,7 @@ static int alloc_identity_pagetable(struct kvm *kvm)
> goto out;
>
> kvm->arch.ept_identity_pagetable = gfn_to_page(kvm,
> - VMX_EPT_IDENTITY_PAGETABLE_ADDR>> PAGE_SHIFT);
> + kvm->arch.ept_identity_map_addr>> PAGE_SHIFT);
>
This is a fix, but as Jan says, separate patch.
> out:
> up_write(&kvm->slots_lock);
> return r;
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2539e9a..977b705 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2178,7 +2178,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> goto out;
> break;
> case KVM_SET_IDENTITY_MAP_ADDR: {
> - u64 ident_addr;
> + unsigned long ident_addr;
>
> r = -EFAULT;
> if (copy_from_user(&ident_addr, argp, sizeof ident_addr))
>
This doesn't look right. Consider 32-bit userspace running on a 32-bit
kernel and the same userspace running on a 64-bit kernel. We need to
copy the same size in both cases.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-03 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 6:17 [PATCH] KVM: Fix EPT identity IOCTL on 32pae Sheng Yang
2009-08-03 11:48 ` Jan Kiszka
2009-08-03 12:25 ` Avi Kivity [this message]
2009-08-03 13:38 ` Sheng Yang
2009-08-03 16:47 ` Marcelo Tosatti
2009-08-03 16:50 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A76D747.2060506@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.