From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, quintela@redhat.com, hch@lst.de
Subject: Re: [PATCH] qemu-kvm: fix no gsi routing warning
Date: Wed, 23 Sep 2009 12:04:19 +0300 [thread overview]
Message-ID: <4AB9E493.9040108@redhat.com> (raw)
In-Reply-To: <20090921195024.GA29784@redhat.com>
On 09/21/2009 10:50 PM, Michael S. Tsirkin wrote:
> On Mon, Sep 21, 2009 at 05:56:13PM +0300, Avi Kivity wrote:
>
>> On 09/21/2009 05:51 PM, Michael S. Tsirkin wrote:
>>
>>> When running on host kernel which does not let the guest manupulate the
>>> gsi routing, and user requested MSI-X to be enabled, we get the
>>> following warnings:
>>> kvm_msix_add: kvm_get_irq_route_gsi failed: No space left on device
>>> kvm_msix_update: kvm_update_routing_entry failed: Invalid argument
>>>
>>> What really happens is that we report a failure to allocate
>>> a vector to the guest, it will retry and finally disable MSI.
>>>
>>> Make this clearer by checking for gsi capability and warning about
>>> the error in a readable form.
>>>
>>>
>>>
>> Can we disable msix
>>
> What we do effectively disables msix.
>
>
>> (or, abort qemu at startup and request that the user
>> disable msix) if the kernel doesn't provide required features?
>> It's
>> better than a runtime error.
>>
> Note it's a warning, not an error.
>
> We have a similar failure mode when we run out of gsi entries, and that
> can not be checked upfront. I prefer having it fail in the same way, so
> that this failure path in guest drivers is excercised and tested.
>
I see, applied the patch, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-09-23 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 14:51 [PATCH] qemu-kvm: fix no gsi routing warning Michael S. Tsirkin
2009-09-21 14:56 ` Avi Kivity
2009-09-21 19:50 ` Michael S. Tsirkin
2009-09-23 9:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB9E493.9040108@redhat.com \
--to=avi@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.